Justin Chen

Chat: unify Agent Host status pills across chat surfaces (#332982) * Agent Host changes for agents/editor-chat-panel-pills-enhancement * chat: scope pill resize observer to host window Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 44dd6d62-f5b5-4039-8c99-7cd70e43d9a3 * chat: collapse status pills only on overflow Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 44dd6d62-f5b5-4039-8c99-7cd70e43d9a3 * chat: address pill review feedback Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 44dd6d62-f5b5-4039-8c99-7cd70e43d9a3 * chat: include subagent browsers in status pills Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 44dd6d62-f5b5-4039-8c99-7cd70e43d9a3 * chat: keep session input pills Agent Host-only Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 44dd6d62-f5b5-4039-8c99-7cd70e43d9a3 * agentHost: share session resolution policy Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 44dd6d62-f5b5-4039-8c99-7cd70e43d9a3 * chat: unify session input pills Route Agents Window and Agent Host editor/panel pills through one shared controller and canonical source builder. Remove the obsolete SessionHeaderMeta pill implementation, preserve live GitHub state through shared presentation models, and stabilize dropdown, focus, compact-layout, and changeset lifecycles to avoid flicker. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 44dd6d62-f5b5-4039-8c99-7cd70e43d9a3 * chat: fix session pill fixture services Allow production chat widget fixtures to register feature-specific services, and reuse one session-pill service bundle for isolated and full-chat fixtures. This restores the strict Component Explorer renders without duplicating mocks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 44dd6d62-f5b5-4039-8c99-7cd70e43d9a3 * bring back rich pill hovers --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: BeniBenj <besimmonds@microsoft.com> Copilot-Session: 44dd6d62-f5b5-4039-8c99-7cd70e43d9a3

chat: add opt-in persistent working progress (#336087) * chat: add opt-in persistent working progress Keep a stable progress indicator through thinking, tools and interactive prompts while preserving the collapsed-thinking exception and legacy behavior when disabled. Add configurable VS Code logo motion, regression coverage and live component fixtures. Preserve terminal and rich subagent activity animations, and undo the requested picker-label offsets. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: unify persistent progress and fix review regressions Use one off-by-default animation enum for persistent progress. Keep approval status and footer ordering correct, preserve progressive reveal after interactions, track MCP authentication completion in the producer and response model, and restore verbose progress announcements.\n\nFix the reduced-motion terminal assertion and the nested MCP test, with configuration, lifecycle, and live-fixture regression coverage.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fold completed persistent responses and surface edit totals Persistent progress now honors chat.agent.collapseCompletedResponses: completed responses fold their expanded tool chains into "Completed N steps", counting individual chain rows, and the summary gains a shared edit-stats button that aggregates the response's file changes and opens the multi-diff editor. The same button backs the thinking-header diff pill. Also normalizes spacing for edit pills and markdown inside persistent tool chains, adds a mock editing session so native markdown edit pills render in tests and fixtures, and marks the setting as experiment-controlled (default Off) with matching accessibility help and setting descriptions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 582f8a6c-b5dc-415f-a695-2ed8fdd8effd * Stop persistent spacing and header height from depending on stylesheet order The persistent spacing rules tied on specificity with main's `.interactive-item-container .value > .chat-tool-invocation-part` margin, so whichever stylesheet was imported first won; with every unit test file loaded, the legacy 16px margin beat the shared gap token. Including the row container class makes the persistent rules win outright. Tool detail headers inherit a 1.5em line height computed at the response font size while their label text is smaller, and Chromium builds disagree on whether that block line height governs the label box (Playwright's Chromium lays it out 1.5px short). Give the label text the header line height directly so both engines agree. Also allow one device pixel for the connector stroke checks at fractional zoom, where Chromium snaps 1px strokes to whole device pixels. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 582f8a6c-b5dc-415f-a695-2ed8fdd8effd * Address adversarial review of persistent progress Footer state: tools waiting for MCP authentication and unused legacy confirmation parts now surface as blocking states instead of a generic working phrase, the per-tool watcher refreshes on those transitions, and blocking labels are announced to screen readers once (rotating phrases stay silent). Participant progress messages and unfinished tasks become the footer text instead of being hidden behind it, and their rows fall back to the check icon rather than a static spinner glyph. Carousel: tool parts built for the input part's confirmation carousel use a context without persistent presentation, and the gutter icon is scoped to the response so it can no longer leak layout into another host. Edit totals: content parts that render edits expose their current diff (IChatContentPartDiffSource) so chains and subagents seed from values that were emitted before they attached, for example restored sessions with cached diffs. The completed-response aggregation collects each chain once (hooks returned the same instance at several indices, doubling totals), and now includes standalone edit markdown and subagent edits. Also: the disclosure fast path recounts steps when chain rows are removed after completion, a persistent reasoning preview defers its auto-collapse until keyboard focus leaves it, and unknown animation values warn once. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 582f8a6c-b5dc-415f-a695-2ed8fdd8effd --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 582f8a6c-b5dc-415f-a695-2ed8fdd8effd

chat: add pet achievements and accessory rewards (#331883) * pet: add achievements and accessory rewards Add persistent cross-window pet achievements with six enabled rewards, a standalone collection modal, account badges, and semantic unlock triggers. Add the body-owned accessory rig and atlases, unlock star and New state, accessibility help, fixtures, and tests while retaining disabled rewards for later re-enablement. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5c8a4f1e-3bb0-4d6f-a3ed-249fbcd4ce15 * pet: address achievement review feedback Defer customization observation until the pet is enabled, detect newly installed MCP servers independently of enablement, and fully clear legacy fork state on reset. Rename the Crown persistence ID and use contrast-paired badge colors for the New affordance. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5c8a4f1e-3bb0-4d6f-a3ed-249fbcd4ce15 * pet: update model and skill rewards Reward changing the model picker selection with the Construction Hard Hat, and reward adding a custom skill with the Crown. Keep the instructions achievement and Sailor Hat disabled for future use. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5c8a4f1e-3bb0-4d6f-a3ed-249fbcd4ce15 * pet: fix component fixture asset loading Serve pet fixture media from the source tree used by both Vite and the CI rspack server, remove the intentionally empty screenshot variant, and approve the new blocking fixture snapshots. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5c8a4f1e-3bb0-4d6f-a3ed-249fbcd4ce15 * pet: accept component fixture screenshots Record the authoritative Linux CI hashes for the new blocking pet achievement and accessory fixtures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5c8a4f1e-3bb0-4d6f-a3ed-249fbcd4ce15 * pet: restore fake timers within unlock test Avoid leaving the renderer test clock installed after the unlock-state interaction test so later notebook and notification suites can advance timers normally. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5c8a4f1e-3bb0-4d6f-a3ed-249fbcd4ce15 * remove unused achievements for now * pet: remove unrelated branch changes Restore server command, session artifact, and chat pill files to current main after they were accidentally included with the dormant achievement cleanup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5c8a4f1e-3bb0-4d6f-a3ed-249fbcd4ce15 --------- Copilot-Session: 5c8a4f1e-3bb0-4d6f-a3ed-249fbcd4ce15

Fix subagent activity, opening, and completion state (#334986) * chat: fix subagent activity, readiness, and completion Recover failed child subscriptions through chat catalog discovery, keep restored subagent pills observable, and gate opening on resolved child chats. Preserve completed tool labels and surface missing-chat errors instead of blank editable editors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: address subagent lifecycle review feedback Scope child discovery to the spawning chat, restore cross-client and nested subagent availability, and adopt completed client snapshots without duplicate pills. Keep cancelled tools from showing success labels and preserve synchronous setup for already-hydrated child chats. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: retain rich subagent presentation while awaiting child chats Separate rich pill visibility from chat navigation readiness, preserve activity after the launch tool completes, and keep unavailable output accessible. Cover the actual toolbar lifecycle and add dark/light fixtures for pending, running, and unavailable child chats. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: invalidate subagent availability on late subscription errors Observe child subscription failures throughout the observation lifetime, clear stale activity and availability, release the failed observer, and allow subsequent catalog recovery. Clarify prospective chat resources and legacy undefined availability semantics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: always use collapsed preview thinking in read-only chats Pass read-only state through the shared renderer and content context, overriding only the effective thinking style without changing user configuration. Rebuild reused templates when read-only state changes and apply the override consistently to grouping and completion. Cover all configured modes and editable/read-only transitions, and document the behavior in settings and accessibility help. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: suppress launch output in rich subagent headers Keep rich subagents pill-only while launch completion, availability and child activity transition independently. Remove the temporary Subagent output disclosure and its action-enabled listeners, preserve opt-out inline rendering, and cover live/restored launch acknowledgments and the inactive initialization gap. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: defer subagent entries and name completion notices Publish subagent entries only after a child turn exists, appending them after intervening progress rather than reserving an early slot. Preserve observation and ordering across live, same-client, cross-client, and restored turns, and verify the full renderer in both themes. Use the SDK display name or task description for live and restored background-agent completion notices instead of an opaque routing ID. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: distinguish agent titles in completion notices Use the existing escaped Markdown inline-code helper for background-agent names in live and restored notices. Cover embedded backticks, literal link syntax, accessible plain text, and dark/light rendering. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: break thinking at system completion notices Finalize the current thinking group at a system notification and give subsequent parent reasoning a fresh protocol part. Keep running subagent reasoning independent and mount new collapsed tool groups after the boundary. Cover live reasoning, replay, all thinking styles, read-only and incremental rendering, completed/remounted responses, and visible DOM ordering with full-renderer fixtures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: follow list lifecycle in subagent fixtures Dispose the previous element render before reusing the full-response template, as the production list does. This clears progressive-render timers instead of exhausting the component explorer's virtual-time task budget. Verified all 14 subagent fixtures twice with the CI render command, deterministic screenshot hashes, and unchanged output for previously passing fixtures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: preserve late subagents and contained edit previews Keep subagent launch metadata, deferred publication, and child observation alive with the session so children can start after their parent turn completes. Recover deferred idle history, route late progress to the original response, and honor catalog children for failed active-turn restores. Keep provider-observed children visibly active until their own completion, and only mount newly split thinking-group roots so lazy edit markdown stays inside its collapsed group. Add regressions for all contributor paths, delayed catalog recovery, original-response routing, disposal, failed restoration, and edit containment. Verified 865 tests and 16 CI-style component fixtures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

chat: add timestamps and elapsed time (#325061) * chat: add timestamps and elapsed time * put behind setting! * fix tests * ah timestamp fixes and better animations! * switch to use new protocol changes * bump ahp version --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Implement experimental mode and permissions picker integration (#334972) * Agent Host changes for agents/experimental-mode-permissions-picker * address some comments and cleanup * chat: refine stacked mode and permissions picker for Insiders Replace the permissions flyout with inline expansion and independent mode and permission highlights. Preserve keyboard focus, use the available menu height, and align composer control sizing and spacing. Enable the experiment by default in non-Stable builds while preserving explicit user overrides. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: adapt picker tests to upstream pointer and height behavior Exercise pointer movement before hover assertions and inherit the shared chat control height in compact-picker coverage after rebasing onto main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: update combined picker screenshot baselines Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: fix new-session picker styling and initial hovers Align the new-chat controls with the editor and in-session pickers without clipping model sections or adding duplicate padding. Clear recycled icon colors and keep passive state refreshes from opening permission hovers. Add regression coverage for both opening paths and new-chat layouts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: refresh picker baselines after syncing main Copy the ten visually reviewed hashes from Linux CI run 34415280459. Preserve all 153 fixture IDs and unrelated upstream baselines for #334972. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

chat: unify subagent pills and fix tool rendering lifecycles (#338064) * chat: unify subagent pills and fix tool rendering lifecycles Use the shared subagent pill across harnesses, with inline details when no child chat is available, and remove the legacy dropdown setting. Share standalone and chained tool icons, remove empty progress rows and redundant terminal error chrome, and preserve patch results and child edit ownership across live and restored sessions. Remount deferred content only when connected and stop progress when responses finish. Add regression coverage and themed fixtures for confirmations, tool errors, code-block first paint, subagent details, and rendering lifecycles. Fixes #337773. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: exclude hidden tools from chain step counts Keep tool ownership intact while excluding invisible rows from displayed step counts and expansion. Refresh fallback summaries on visibility changes and clear hidden state when entries leave the chain. Cover mixed visibility in both insertion orders, lazy materialization, removal, generated summaries, and live/restored tool chains. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: preserve edit icon layout across stylesheet order Exclude activity-gutter icons from the inline Markdown icon alignment rule without changing its specificity. The conflicting rule previously returned edit icons to normal flow when the full suite loaded CSS in a different order, shifting labels and failing all six CI test jobs. Exercise the real Markdown rule loaded last in every standalone edit-icon regression so focused tests catch the same layout failure as CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

chat: refine persistent progress rendering (#337425) * chat: refine persistent progress rendering Enable persistent progress by default with verbose and compact tool rendering. Collapse previews before revealing subsequent content, align progress connectors, and avoid duplicate reasoning headings and redundant question-tool rows. Preserve standalone tool presentation, add rendering fixtures and regression coverage, and fix tracked disposal of pending progress handoffs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: default to Draw and Compact and fix confirmations Make Draw and Compact the persistent progress defaults, migrate the retired notVerbose value, and preserve explicit presentation choices. Capture the confirmation carousel input owner during registration so session teardown never dereferences a disposed widget. Reuse one identical native shell approval without weakening managed approvals, request identity, or cancellation boundaries. Fixes #337234 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: anchor persistent progress as it collapses upward Keep preceding content and disclosure headers stationary by preserving the transcript's scroll height during collapse. Let subsequent content consume the released space while respecting user scroll intent and auto-scroll holds. Cover automatic and manual reasoning, tool-chain, and completed-response collapse with regression tests and at-bottom fixtures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: respect explicit motion settings during progress collapse Honor the workbench motion override in collapse-body and compact-header styles while retaining the system reduced-motion fallback. Pin the configured-logo test to an explicit motion context and cover unconfigured system behavior. Fix the macOS Electron-Unit failures in #337425. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: harden persistent progress and MCP tool rendering Keep completed responses idle instead of repeatedly regrouping hidden tools. Preserve reasoning code, focused tool content, and explicit bottom navigation. Retain tool failure state in live and restored responses and accessible output, and use MCP source icons consistently. Refs #337425. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix fixtures * fix fixtures part 2 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

agentHost: fix background subagent lifecycle and recipient labels (#337620) * agentHost: fix background subagent reuse and inline progress Preserve reusable child routing on cancellation and settle unroutable approval requests instead of buffering indefinitely. Restore live inline subagent observations across history hydration, including reused turns and new tool approvals. Fixes #337339. Refs #335292. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: address subagent lifecycle review feedback Retire cancelled child execution state through the existing completion cleanup so reuse cannot inherit usage or Auto routing. Bound failed routing suppression separately and release disposed signal buffers immediately. Add regression coverage for cancelled usage, late completion, failed-route eviction, scoped cleanup, and reentrant permission denial. Addresses review feedback on #337620. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: refresh MCP provenance screenshot baseline Accept the CI-generated light-theme baseline for the MCP provenance fixture. The recorded difference is limited to insignificant border antialiasing. Refs #337620. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: tolerate skipped pet teleport animation frames The sprite player advances from elapsed time, so busy CI runners can legitimately skip intermediate frames. Verify both phase endpoints and reverse/forward ordering while retaining geometry, visibility, landing and focus assertions. Refs #337620. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test: stabilize MCP provenance fixture painting Defer painting until the fixture is ready to avoid intermediate-paint antialiasing noise, and restore the latest CI baseline. Repeated targeted captures were stable in both themes. Refs #337620. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: show readable write-agent recipients Resolve agent names from lifecycle events, completion notifications and runtime task metadata in live and restored chats. Name each recipient for multi-agent writes while preserving raw routing IDs and the existing unknown-ID fallback. Validated with 880 focused tests and a live Code OSS/AHP scenario covering single-recipient writes, broadcasts and renderer reload. Refs #337620. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

chat input: refactor and responsiveness (#332669) * chat input: refactor and responsiveness * address comments * address comp --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>