Shai Szulanski

Reimplement toDebugString as a protocol Summary: Replace the recursive debug-string renderer with `DebugStringProtocolWriter` and transcode directly from the supplied protocol reader. This preserves caller-configured depth, string, and container limits and consumes exactly one struct without cloning the unread tail. Exceptions propagate without attempting to recover the now-invalid protocol reader or writer. Reviewed By: vitaut Differential Revision: D120422513 fbshipit-source-id: 9c5e699cc0b562ae89ca79488cfd811a63e73b8e

Store path selectors as `DynamicValue` Summary: Store set elements and map selectors directly as `DynamicValue` and retain `TypeRef` for Any traversal. Traversal consumes selectors in place in `DynamicValue.cpp`, and schema validation advances type context without inventing typed keys for ordinal-only diagnostics. Reviewed By: praihan Differential Revision: D117553807 fbshipit-source-id: 0e422ba7cb29a71f151e38faea7b441fe6a3a1f7

Define concepts for adapters Summary: Define `ThriftConstAdapter`, `ThriftTypeAdapter`, `ThriftFieldAdapter`, and `ThriftAdapter` concepts together with concepts for the runtime customization points: construct, clear, isEmpty, comparison, hash, in-place conversion, serialized size, encode, and decode. Migrate runtime detection and dispatch from SFINAE/`folly::overload` probes to constraints and `if constexpr`. The new predicates match the calls they guard: `less` and `serializedSize` are const-correct, serialized-size detection uses the real `ZeroCopy` value, field-adapter detection uses the real `FieldId`, and adapted hashing checks invocability. This also removes an accidental default-constructibility requirement on adapters. The adapter inventory covered structured and legacy `cpp.adapter` annotations, including field-only and constant-only adapters, move-only adapted values, by-value and mutable in-place `toThrift`, inline/incomplete wrappers, custom protocol hooks, templated adapters, indirection, comparison/hash hooks, and legacy Carbon adapters. Reviewed By: vitaut Differential Revision: D116515187 fbshipit-source-id: d9cafb64c7a54f2b9d9f8da6834d3c6ee611c4d4

Enforce DynamicValue size limits during construction Summary: Prevent dynamic strings, binaries, lists, sets, and maps from growing beyond `INT32_MAX`. The checks run before allocation and cover every concrete container implementation, including deserialization and record conversion paths that populate them. Set and map insertion still permits existing-value updates at the size boundary. Reviewed By: praihan Differential Revision: D118888435 fbshipit-source-id: 062cbf789b527840dde31b2d19b81b8933e58017

Implement path string parsing Summary: Allows reading a path string back into a `Path` given its type and typesystem. The leading type name is for human friendliness only and is not consumed if present; remaining identifiers are parsed and validated against the provided type to ensure the `Path` is valid when returned. Reviewed By: praihan Differential Revision: D118886536 fbshipit-source-id: b31daab1b96f80accb913cfcbc0081a9d256adf7

Enforce depth limits in optimized struct reads Summary: Apply the standard protocol depth accounting to Binary and Compact `StructReadState` entry and exit. Add generated table-based deserialization coverage at the exact nesting limit and one level beyond it. Document that abandoning a cursor or unwinding through an exception invalidates the underlying protocol reader or writer, permit cursor teardown during unwinding without attempting recovery, and preserve the original protocol exception. Reviewed By: vitaut Differential Revision: D121232416 fbshipit-source-id: d4bea46b6729fdfe187987dcdb802e6d2e28382b

Convert between concrete and dynamic values Summary: Add standalone conversions between concrete Thrift-compatible C++ values and schema-typed `DynamicValue` values. Traverse concrete values directly using Thrift type tags and runtime schema metadata, without serialization or an intermediate representation. Compile-time scalar tags must match the runtime kind (opaque aliases are matched through their underlying kind), and already-dynamic inputs must already have the requested type identity. Preserve runtime enum and opaque-alias types and reserve container storage. Reviewed By: ahilger Differential Revision: D117598089 fbshipit-source-id: 532e19040b81a6e5aa7b3fe46a78c335489f37a5

Support immutable references in op list decoding Summary: Decode list elements into a temporary before emplacement when the container exposes a const reference type. This preserves support for immutable-reference list-like containers in the tag-dispatched decoder. #buildall Reviewed By: Mizuchi Differential Revision: D118553961 fbshipit-source-id: 74a9ea55ea46893616483356984aba177ee38eda

Preserve container allocators during decode Summary: Generic container decode currently replaces the destination with a default-constructed container before reading. For allocators that propagate on move assignment, that discards caller-provided allocator state. Clear lists, sets, and maps in place instead; decode retains its empty-before-read behavior while preserving allocator and policy state. The sorted-vector bulk path reconstructs its optimized backing container, so it now explicitly carries the existing comparator through that reconstruction. Its optimization constraint also verifies those comparator-aware constructors exist; other custom containers use the ordinary insertion path. For standard sequence and hash containers, clearing intentionally retains capacity or buckets so reused objects do not release and reacquire storage on every decode. Reviewed By: vitaut Differential Revision: D117403536 fbshipit-source-id: 63815ff79df6e881e282bf99fb28f4c689d20fcf

Add deterministic C++ type migration codemods Summary: Add conservative Thrift compiler codemods and CodemodService configs for migrating equivalent container `cpp.Type` annotations to `template` and allowlisted string/binary overrides to `StringTypeAdapter`. Both transformations fail closed for semantic changes that require hand-authored adapters, typedef extraction, Py3 annotations, or custom serialization. The type->template migration prevents simultaneously changing the template type and the element type, which results in a missing `cpp_type` wrapper around the element type in the overall type tag. Reviewed By: vitaut Differential Revision: D117896675 fbshipit-source-id: a233f8fee27ba52f8deeff8e3bf1a6c5cece32af