Daniel Sanche

chore: regenerate libraries with gapic-generator @ a7e09c9a7 (#18254) Following pattern of https://github.com/googleapis/google-cloud-python/pull/18243, updating the generator to the latest version, and re-generating files Commit https://github.com/googleapis/google-cloud-python/commit/a25794ebfb2df00ace8817458a4e0020f7402a99 contains manual changes to post-processing scripts, to [apply lint fix](https://github.com/googleapis/google-cloud-python/pull/18134/changes/1059110d773797bfee36b91728606e287a38e993#diff-eca36c0b45bd63dff01eb9fdfc775b2c280abb0d84d80df594dbd45c7c21f3acL469-L474) Commit https://github.com/googleapis/google-cloud-python/commit/7c6e76ec177972d4e35419b330a26d237187f162 re-generated the files using gapic-generator at commit a7e09c9a7

feat(bigtable): client side metrics handlers (#16760) Migrate https://github.com/googleapis/python-bigtable/pull/1189 to the monorepo This PR builds off of https://github.com/googleapis/python-bigtable/pull/1187 to add handlers to the client-side metrics system, which can subscribe to the metrics stream, and export the results into different collection systems We add two handlers to the system: - `GoogleCloudMetricsHandler`: sends metrics to a private OpenTelemetry meter, and then periodically exports them to GCP. Built on top of `OpenTelemetryMetricsHandler` - `OpenTelemetryMetricsHandler`: sends metrics to the root MeterProvider, so the user can access the exported metrics for their own systems. This will be off by default, but can be added alongside `GoogleCloudMetricsHandler` if needed --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

feat(bigtable): initialize internal data client in classic client (#18080) Migrating over @gkevinzheng PR from bigtable monorepo https://github.com/googleapis/python-bigtable/pull/1238 Original description: > Changes: > - Added a new property ~`new_table_data_client`~ `_veneer_data_client` in the classic client for the new table data client > - Added two hidden kwargs (`client_info` and `disable_background_channel_refresh`) to the new data client constructor to support the classic client. > > Fixes googleapis/google-cloud-python#15298 Note to reviewers: This PR has already been reviewed and merged to a staging branch, with the intention of doing a single merge to main. We are now planning to slowly rollout these changes back to the main branch. Minimal re-review should be necessary --------- Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

chore(tests): enable core_deps presubmit check (#18233) This PR re-enabled the core_deps check on pre-submit, with a few changes. This test triggers the `core_deps_from_source` nox session, which will run the unit tests against the unreleased copy of the library present in the codebase Unlike the previous test: - we take advantage of the new sharding system - this one only targets handwritten libraries, not all packages in the repo - tests are trigged for all handwritten libraries when any core dependency is changed (auth, api_core, proto_plus, etc), or if the test config changed This change also modified noxfiles, to better support preview packages, and avoid downloading over the network when possible Tests are blocked on https://github.com/googleapis/google-cloud-python/pull/18230

tests(bigtable): System/compatibility tests for testing shim compatiblity (#17901) Migrating over @gkevinzheng PR from bigtable monorepo https://github.com/googleapis/python-bigtable/pull/1218 Original description: > Additional system tests for testing shim compatibility with the classic client interface. > >Also fixes a bug where encountering a retriable error after another retriable error mid-stream raised an exception instead of retrying. > > Fixes https://github.com/googleapis/python-bigtable/issues/1156 Note to reviewers: This PR has already been reviewed and merged to a staging branch, with the intention of doing a single merge to main. We are now planning to slowly rollout these changes back to the main branch. Minimal re-review should be necessary --------- Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

feat(bigtable): Rerouted CheckAndMutateRows and ReadModifyWriteRows to data client (#18190) Migrating over @gkevinzheng PR from bigtable monorepo https://github.com/googleapis/python-bigtable/pull/1257 ### Original description: > **Changes made:** > > - `Row` objects hold `Mutation` and `ReadModifyWriteRowRule` objects from the data client rather than raw protos. > - Rerouted `ConditionalRow.commit` and `AppendRow.commit` (CheckAndMutateRows and ReadModifyWriteRows respectively) to use the data client, or more specifically, `self._table._table_impl` > - Added function `DirectRow._to_mutation_pbs` for retrieving mutations in proto form for the current `MutateRows` implementation, as well as for `DirectRow.get_mutations_size`. > - Removed unnecessary helper functions and tests for helper functions Note to reviewers: This PR has already been reviewed and merged to a staging branch, with the intention of doing a single merge to main. We are now planning to slowly rollout these changes back to the main branch. Minimal re-review should be necessary --------- Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com>

chore(bigtable): Rerouted legacy client row filters to data client row filters (#18175) Migrating over @gkevinzheng PR from bigtable monorepo https://github.com/googleapis/python-bigtable/pull/1255 ### Original description: > Changes made: > - Used import aliasing to remove most of the legacy client row filter code and use the data client row filter code in its place. > - Some of the data client row filter classes had to be slightly modified for backwards compatibility with the legacy client row filter classes' interface. > - As part of this move, `to_pb` has been replaced with `_to_pb`, and I have adjusted references to `<RowFilter>.to_pb` in the libraries and unit tests. > > This is for eventually shimming up `CheckAndMutateRows`, and other row mutation operations as well. ### Additional changes on top of Kevin's: - ([3097276](https://github.com/googleapis/google-cloud-python/pull/18175/commits/309727697016b165294e56a6ab7e90723e8f7630)) I added an alias between the new `_to_pb()` and the old `to_pb()` methods, for backwards compatibility - Originally, we were planning on dropping the method. Now, it can still be used, with a deprecation warning Note to reviewers: This PR has already been reviewed and merged to a staging branch, with the intention of doing a single merge to main. We are now planning to slowly rollout these changes back to the main branch. Minimal re-review should be necessary --------- Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com>

chore(tests): re-enable cover tests (#17454) The cover CI test was silently failing open. This PR re-enables it Fixes https://github.com/googleapis/google-cloud-python/issues/17456

chore: add test sharding to unit tests (#17438) Added test sharding for unit and mypy tests: - added `initialize` job to unit test CI. It analyzes the modified packages, and spawns up to MAX_SHARDS jobs for each supported Python runtime - long-running packages can have a multiplier added in PACKAGE_WEIGHTS. This will cause the system to reserve more time for long-running tests, to better distribute the workload across shards - shards are added according to the formula `shards_used = min(1, max(MAX_SHARDS, total_package_weight / 10)) - adds an end `unit test complete` step, which is only green if all shards pass. This can be our new required check for unit tests - if any single unit test shard fails, the remaining end early to provide quick feedback - preview packages will also be selected when modified, and put in the same shard as their parent package (for easier discovery) Before merge: - we need to update the required checks. We can do this after approval, but before merging --------- Co-authored-by: Anthonios Partheniou <partheniou@google.com>

feat(bigtable): Rerouted MutateRows to use the data client (#18195) Migrating over @gkevinzheng PR from bigtable monorepo https://github.com/googleapis/python-bigtable/pull/1290 ### Original description: > **Changes Made:** > > - Rerouted MutateRows to use the data client's `Table.bulk_mutate_rows` function. > - Reworked error handling in `Table.mutate_rows`. Since we must return a list of `Status` objects, we process the list of errors obtained from the `_MutateRowsOperation` back into a corresponding list of error statuses. > - Reworked retries in `Table.mutate_rows` as follows: > - `retry.deadline` -> `operation_timeout` > - `timeout`/`mutation_timeout` -> `attempt_timeout` > - A null retry deadline now defaults to the table default mutate rows operation timeout instead of being defined as no timeout. The docstring has been updated to reflect that. A retry deadline of 0.0 will still be a no-retry option, and is implemented by setting the list of retriable errors to the empty list, and the operation timeout to the default mutate rows operation timeout. > - A `timestamp` of `None` in `set_cell`, which is the default, will now generate a client-side timestamp representing the current time, rather than defaulting to using the server-side timestamp. The docstrings for this have been updated to reflect this. > Note to reviewers: This PR has already been reviewed and merged to a staging branch, with the intention of doing a single merge to main. We are now planning to slowly rollout these changes back to the main branch. Minimal re-review should be necessary --------- Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com>