Daniel Sanche

chore: regenerate libraries with gapic-generator @ a7e09c9a7 (#18254) Following pattern of https://github.com/googleapis/google-cloud-python/pull/18243, updating the generator to the latest version, and re-generating files Commit https://github.com/googleapis/google-cloud-python/commit/a25794ebfb2df00ace8817458a4e0020f7402a99 contains manual changes to post-processing scripts, to [apply lint fix](https://github.com/googleapis/google-cloud-python/pull/18134/changes/1059110d773797bfee36b91728606e287a38e993#diff-eca36c0b45bd63dff01eb9fdfc775b2c280abb0d84d80df594dbd45c7c21f3acL469-L474) Commit https://github.com/googleapis/google-cloud-python/commit/7c6e76ec177972d4e35419b330a26d237187f162 re-generated the files using gapic-generator at commit a7e09c9a7

feat(bigtable): client side metrics handlers (#16760) Migrate https://github.com/googleapis/python-bigtable/pull/1189 to the monorepo This PR builds off of https://github.com/googleapis/python-bigtable/pull/1187 to add handlers to the client-side metrics system, which can subscribe to the metrics stream, and export the results into different collection systems We add two handlers to the system: - `GoogleCloudMetricsHandler`: sends metrics to a private OpenTelemetry meter, and then periodically exports them to GCP. Built on top of `OpenTelemetryMetricsHandler` - `OpenTelemetryMetricsHandler`: sends metrics to the root MeterProvider, so the user can access the exported metrics for their own systems. This will be off by default, but can be added alongside `GoogleCloudMetricsHandler` if needed --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

feat(bigtable): initialize internal data client in classic client (#18080) Migrating over @gkevinzheng PR from bigtable monorepo https://github.com/googleapis/python-bigtable/pull/1238 Original description: > Changes: > - Added a new property ~`new_table_data_client`~ `_veneer_data_client` in the classic client for the new table data client > - Added two hidden kwargs (`client_info` and `disable_background_channel_refresh`) to the new data client constructor to support the classic client. > > Fixes googleapis/google-cloud-python#15298 Note to reviewers: This PR has already been reviewed and merged to a staging branch, with the intention of doing a single merge to main. We are now planning to slowly rollout these changes back to the main branch. Minimal re-review should be necessary --------- Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

feat: Rerouted ReadRows to data client (#18198) Migrating over @gkevinzheng PR from bigtable monorepo https://github.com/googleapis/python-bigtable/pull/1299 ### Original description: > > **Changes Made:** > - Added methods to convert `Row` and `Cell` objects in the data client to `PartialRowData` and `Cell` objects in the legacy client. > - Removed legacy client code related to processing `ReadRowResponse` chunks and testing `ReadRowResponse` chunks. > - Removed `_update_message_request` from `RowSet` because it's no longer needed to create a `ReadRowQuery` > - Rerouted `read_row` and `read_rows` to use their data client counterparts in `table.py`. > ### Additional Changes: Applied some guards against removed semi-private APIs, after internal discussion: - https://github.com/googleapis/google-cloud-python/pull/18198/commits/69411995ba04e6ce29720f8620afe06ba281e341: we had a couple technically public, but not meant to be accessed attributes. This commit replaces them with properties that raise a warning and return None, rather than completely removing them - https://github.com/googleapis/google-cloud-python/pull/18198/commits/c9617acfdb7ca254802b9a3704bf8fccec4c4703: Similarily, the PartialRowsData constructor was technically public, but not intended to be used. This change returns an empty generator when the previous constructor is used, with a warning - https://github.com/googleapis/google-cloud-python/pull/18198/commits/b51292e8db1c1c2d1d856b07bb0246377a9c7d6a: handles a bug that could occur if None is passed for retries - https://github.com/googleapis/google-cloud-python/pull/18198/commits/92da437b1f9bf41567261d0c02d7adaede46d922: added better typing to generator Note to reviewers: This PR has already been reviewed and merged to a staging branch, with the intention of doing a single merge to main. We are now planning to slowly rollout these changes back to the main branch. Minimal re-review should be necessary --------- Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com>

chore(tests): enable core_deps presubmit check (#18233) This PR re-enabled the core_deps check on pre-submit, with a few changes. This test triggers the `core_deps_from_source` nox session, which will run the unit tests against the unreleased copy of the library present in the codebase Unlike the previous test: - we take advantage of the new sharding system - this one only targets handwritten libraries, not all packages in the repo - tests are trigged for all handwritten libraries when any core dependency is changed (auth, api_core, proto_plus, etc), or if the test config changed This change also modified noxfiles, to better support preview packages, and avoid downloading over the network when possible Tests are blocked on https://github.com/googleapis/google-cloud-python/pull/18230

tests(bigtable): System/compatibility tests for testing shim compatiblity (#17901) Migrating over @gkevinzheng PR from bigtable monorepo https://github.com/googleapis/python-bigtable/pull/1218 Original description: > Additional system tests for testing shim compatibility with the classic client interface. > >Also fixes a bug where encountering a retriable error after another retriable error mid-stream raised an exception instead of retrying. > > Fixes https://github.com/googleapis/python-bigtable/issues/1156 Note to reviewers: This PR has already been reviewed and merged to a staging branch, with the intention of doing a single merge to main. We are now planning to slowly rollout these changes back to the main branch. Minimal re-review should be necessary --------- Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

feat(bigtable): Reroute Mutations Batcher to use data client (#18200) Migrating over @gkevinzheng PR from bigtable monorepo https://github.com/googleapis/python-bigtable/pull/1309 ### Original description: > **Changes Made:** > > - Replaced mutations batcher implementation with one based off of the data client. > - Reworked unit tests. > - Added additional system tests. > ### Additional Changes: - https://github.com/googleapis/google-cloud-python/commit/785f1388696cfaad333eea3b1f94c7fc2c16e9f6: fix references in propertoes to point to data client - https://github.com/googleapis/google-cloud-python/pull/18200/commits/ac62f4c123d9bb77502badb85a74ae96920620a3: removed deprecation language around flush_interval, since it is supported in the data client Note to reviewers: This PR has already been reviewed and merged to a staging branch, with the intention of doing a single merge to main. We are now planning to slowly rollout these changes back to the main branch. Minimal re-review should be necessary --------- Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com>

feat(bigtable): Rerouted CheckAndMutateRows and ReadModifyWriteRows to data client (#18190) Migrating over @gkevinzheng PR from bigtable monorepo https://github.com/googleapis/python-bigtable/pull/1257 ### Original description: > **Changes made:** > > - `Row` objects hold `Mutation` and `ReadModifyWriteRowRule` objects from the data client rather than raw protos. > - Rerouted `ConditionalRow.commit` and `AppendRow.commit` (CheckAndMutateRows and ReadModifyWriteRows respectively) to use the data client, or more specifically, `self._table._table_impl` > - Added function `DirectRow._to_mutation_pbs` for retrieving mutations in proto form for the current `MutateRows` implementation, as well as for `DirectRow.get_mutations_size`. > - Removed unnecessary helper functions and tests for helper functions Note to reviewers: This PR has already been reviewed and merged to a staging branch, with the intention of doing a single merge to main. We are now planning to slowly rollout these changes back to the main branch. Minimal re-review should be necessary --------- Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com>

chore(bigtable): Rerouted legacy client row filters to data client row filters (#18175) Migrating over @gkevinzheng PR from bigtable monorepo https://github.com/googleapis/python-bigtable/pull/1255 ### Original description: > Changes made: > - Used import aliasing to remove most of the legacy client row filter code and use the data client row filter code in its place. > - Some of the data client row filter classes had to be slightly modified for backwards compatibility with the legacy client row filter classes' interface. > - As part of this move, `to_pb` has been replaced with `_to_pb`, and I have adjusted references to `<RowFilter>.to_pb` in the libraries and unit tests. > > This is for eventually shimming up `CheckAndMutateRows`, and other row mutation operations as well. ### Additional changes on top of Kevin's: - ([3097276](https://github.com/googleapis/google-cloud-python/pull/18175/commits/309727697016b165294e56a6ab7e90723e8f7630)) I added an alias between the new `_to_pb()` and the old `to_pb()` methods, for backwards compatibility - Originally, we were planning on dropping the method. Now, it can still be used, with a deprecation warning Note to reviewers: This PR has already been reviewed and merged to a staging branch, with the intention of doing a single merge to main. We are now planning to slowly rollout these changes back to the main branch. Minimal re-review should be necessary --------- Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com>

chore(crc32c): set up release scripts (#18400) This PR: - restores the release scripts for crc32c that were removed as part of the monorepo migration - adds extra validation to make sure sdist-only releases will not accidentally be published - adds a release block on crc32c, until we add matching backend configs - move the supported versions list into a centralized location for build scripts, instead of having each script encode it separately