roblourens

agentHost: recover failed Copilot turns in place (#332461) * agentHost: recover failed Copilot turns in place Implement durable same-turn error recovery, zero-message Copilot continuation, race-safe server validation, restart restoration, and Try Again UI coverage. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: sync final AHP recovery output Point the VS Code protocol snapshot at the commit that adds recovery support to the newly merged .NET client. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: harden failed turn recovery Keep retries on the original Agent Host participant, quarantine stale Copilot events across cancellation boundaries, and preserve checkpoint identity across resumable failures. Add focused unit, UI, multi-client, repeated-failure, and interruption E2E coverage. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: assert imported durable error parts Cover the durable error response part emitted when local errored conversations are imported into Agent Host sessions. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: address failed-turn recovery review Defer queued turns while resumable failures remain terminal, exclude failed idle time from response duration, and document Try Again in Chat accessibility help. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: add deterministic failed-turn UI testing Add source-only recoverable failure helpers for launch testing and prevent concurrent confirmation actions while a retry is in flight. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: cover recovery after completed tools Add source-debug launch coverage for a completed tool call followed by a recoverable error, restart restoration, and same-turn continuation without duplicating the tool lifecycle. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: simplify development error injection Enable deterministic recovery helpers for all source products without requiring an attached Node inspector. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: harden concurrent turn recovery Keep retry telemetry attempt-local while accumulating durable direct usage, and preserve observation when another client wins a concurrent resume. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: verify resumed usage presentation Assert that retry credits and per-model token totals are cumulative while context counters reflect the current attempt. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: clarify interrupted turn message (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

agentHost: harden process lifecycle and recovery (#330567) * agentHost: harden process lifecycle Improve Agent Host enablement, startup coordination, reconnect recovery, restart limits, and bounded graceful shutdown. Preserve session worktrees and drain protocol, provider, and persistence work before exit.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: add lifecycle regression coverage Cover structured MessagePort startup failures and management-channel generation rotation across reconnects. Fix the server restart telemetry helper for the CI compiler.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Refactor AgentService instantiation (#331861) * Refactor AgentService instantiation Create an agent-host application DI scope, construct AgentService through it, and remove child-to-parent service re-exports. Update tests to use the production construction path. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Clarify Agent Host DI scope names Use explicit bootstrap and application names for service collections and instantiation services. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Share Agent Host service initialization Use one strict DI scope and centralize common base and provider service setup for both Agent Host entry points. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Streamline Agent Host runtime creation Expose one runtime factory that owns common file, session, DI, AgentService, diagnostics, and optional provider infrastructure initialization. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Move AgentService composition to runtime Construct and register the AgentService core and collaborator graph outside AgentService, use one guarded initialization step for genuine back-references, and replace the test-only clock injection with virtual timers. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Use one complete Agent Host runtime graph Remove optional provider-infrastructure setup, make BYOK policy explicit, and defer Claude SDK environment mutation until first use. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix Agent Host integration fixtures Keep mock-provider configuration distinct from host-owned worktree settings and use an existing workspace for permission containment tests. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Restore Claude SDK initialization behavior Keep the AgentService DI refactor focused by leaving the existing Claude SDK environment setup unchanged. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Adopt a sealed Agent Host service graph (#332036) * Simplify AgentService composition Narrow internal service dependencies, move runtime collaborators out of AgentService, and replace two-phase initialization with a constructor-complete composition. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Define Agent Host service ownership Give the complete Agent Host service graph one disposable runtime owner and document workbench-style placement rules for bootstrap instances, shared orchestration services, and runtime activation. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Document Agent Host service construction Add the target service-placement model and a tested sealable process-local service collection without enabling the seal in production yet. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Create Agent Host service foundation Build callback, state, configuration, authentication, endpoint, proxy, and request foundations before telemetry and share the synchronous path with AgentService tests. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Register Agent Host bootstrap services Migrate bootstrap-owned core and host services to local descriptors, eagerly resolve them under strict DI, and preserve typed test overrides. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Seal the Agent Host service graph Migrate composition-owned and Copilot-dependent services atomically to local descriptors, resolve the complete graph eagerly, and reject late registrations. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Inject AgentService runtime dependencies Make network diagnostics and edit attribution immutable AgentService dependencies and order test-graph teardown after composition-owned listeners. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Activate Agent Host contributions separately Move changeset and completion registrations into an order-preserving post-graph activation phase with explicit disposable ownership. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Finalize the Agent Host service runtime Resolve runtime services through DI, reduce the runtime facade, harden proxy and disposal invariants, and mark the service construction guide current. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Clarify Agent Host child service scopes Define one primary runtime graph while allowing explicitly owned child instantiation services and scoped service collections when isolation requires them. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Document Agent Host service model debt Separate stable service-graph contracts from accepted callback, worktree, foundation, concrete-type, and test-seam warts with explicit exit conditions. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Focus Agent Host bootstrap documentation Rename the service guide, add maintenance rules, explain eager resolution as migration-risk control, and distinguish one primary graph from valid scoped child graphs. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Type customization worktree binding Expose worktree binding as a narrow customization-enablement capability and remove the composition root's concrete implementation assertion. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Remove AgentService state manager escape hatch Route tests through the composition-owned state manager and fix bootstrap cleanup ordering found during review. Clarify descriptor rules for trailing defaulted parameters. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Dispose partial Agent Host contributions Ensure activation failures clean up registrations created earlier in the contribution phase and cover the failure path with a focused test. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Tighten sealed service resolution Allow a sealed descriptor to be replaced only by an instance of its registered constructor, and reject unrelated implementations before descriptor resolution. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Verify SSH host keys for remote agent host connections (#329462) * agentHost: Verify SSH host keys for remote agent host connections The ssh2 ConnectConfig had no hostVerifier, which makes ssh2 accept any host key from any server ("Host accepted by default (no verification)"). Every remote agent host SSH connection was therefore open to impersonation, including harvesting the password typed into our own keyboard-interactive prompt and, with agentForward, access to the user's SSH agent. hostVerifier runs during key exchange, before authentication, so declining now guarantees no credentials ever reach an unverified server. Trust is kept in our own IStorageService-backed store; the user's known_hosts files are read as an additional trust source but are never written to. A changed or revoked key hard-fails with no click-through, recoverable only via the new "Forget SSH Host Key" command, and StrictHostKeyChecking is honored from the user's real SSH config rather than a parallel setting. Host keys a server proves it owns via OpenSSH's UpdateHostKeys extension are learned silently, so legitimate rotations do not surface as failures. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Allow time to answer the SSH host key prompt ssh2's readyTimeout covers the whole handshake and keeps running while hostVerifier awaits a verdict, so the existing 30s window would abort the connection out from under a user doing exactly what the host key dialog asks: going to compare the fingerprint against another source. Verified against a live server that readyTimeout does fire while a verdict is pending. Waiting longer is safe here because these prompts only occur after the server has proven responsive (we are holding its host key), so this window is not what guards against an unreachable host. Background reconnects never prompt, so they keep the short window and still abandon a stalled handshake promptly. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Harden SSH host key verification after review Fixes found by code review and confirmed against OpenSSH 9.9: - Revoked host keys were accepted when StrictHostKeyChecking was no/off, because the opt-out was evaluated before the revocation check. Real ssh still reports "REVOKED HOST KEY DETECTED" under that setting and disables password auth, keyboard-interactive auth and agent forwarding. Disabling host key checking means "I accept unknown keys", never "I accept keys I have explicitly revoked". - An UpdateHostKeys announcement could overwrite a genuine stored key from a session that was never verified (StrictHostKeyChecking=no), so an impostor's key would be trusted once strict checking was restored. ssh2 proves announced keys belong to whoever we are talking to, which says nothing about whether that party is the real host. Announcements are now honored only when the key that authenticated the session is itself trusted, matching OpenSSH's documented rule. - A clean mid-handshake close left the connect promise pending forever: ssh2 emits only end/close with no error and clears its own timeout. Verified with a server that drops the connection after the banner. - A connection dying while known_hosts was being read could register a verification for an already-dead connect, leaking a pending entry and prompting about a connection that was gone. - Replaces the previous blunt 5 minute readyTimeout, which made an unreachable host take minutes to fail. The handshake deadline is now ours (ssh2's is disabled, verified that readyTimeout:0 does so) and is widened only for the interval a prompt is actually outstanding. Also corrects doc comments that said "main process" for a service that runs in the shared process. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Document and cover the stale host key dialog case IDialogService.confirm accepts no CancellationToken and offers no programmatic dismissal, so a host key modal opened for a connection that subsequently dies stays on screen. That is cosmetic rather than unsafe: the caller re-checks cancellation before acting on the answer, so a late "Connect" can neither persist trust nor revive a dead connect attempt. Documents the limitation and adds a test that locks in the safety property. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Dismiss the SSH host key prompt when the connection dies I previously concluded this was not fixable because IDialogService.confirm takes no CancellationToken. That was wrong: the token lives on the options object (IBaseDialogOptions), not the method signature. It only applies to custom dialogs, which is why the existing precedent for a dismissable confirmation pairs `custom` with `token`. So the prompt now tears itself down when the connection drops instead of stranding the user with a question about a connection that no longer exists. Answering late was already inert, and the test now asserts both properties rather than just the latter. Also fixes doc comments that described the old ordering in the host key policy and referred to ssh2's readyTimeout, which we no longer use. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Report a refused SSH host key without ssh2 jargon Declining a host key surfaced "Failed to connect via SSH to macbook-air: Error: Host denied (verification failed)" — ssh2's internal wording, and redundant on top of the host key UI, which has already either been dismissed by the user or shown a specific error with a recovery action. A refused key now rejects with SSHHostKeyDeniedError, which the connect UI treats like a cancellation and does not report again. The guard matches on the error name because the error is raised in the shared process and inspected in the renderer, where only name/message survive IPC serialization. Only a verdict from the renderer is treated this way. Node-side fail-closed paths (a malformed key, or an error while reading known_hosts) still surface a visible error, since nothing else would tell the user the connection went nowhere. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

agentHost: stream rich tool call progress (#327765) * agentHost: stream Copilot tool call arguments Render tool invocations while their arguments are still being generated, preserving final tool metadata and client-tool execution semantics.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: sequence streamed client tool updates Ensure partial-input handlers finish in order before client tool execution, and release pending streams when protocol completion wins the race. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: finalize streamed tool metadata at ready Allow Ready actions to replace provisional contributor and intention metadata so MCP tools can stream immediately while retaining correct execution, rendering, and telemetry semantics. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: simplify streamed tool call lifecycle Limit partial streaming to server-owned tools, preserve client execution ownership, and separate telemetry attribution from invocation timing. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: harden partial tool input display Fall back to raw streaming input for empty partial objects and avoid exposing cached parser objects. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: enrich streamed edit messages Compute progressive file and line-count messages in Agent Host while keeping incremental tool arguments off the AHP wire. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: stream rich Claude edit progress Share rich edit progress formatting across Copilot and Claude while preserving client-tool identity through live and replay lifecycles. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: test streamed tool progress end to end Add deterministic Copilot and Claude coverage for rich message-only file progress and client-tool ownership. Flush Claude's final progress update at the content-block boundary so line counts do not remain stale below the geometric checkpoint. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: normalize streamed file E2E line endings Compare replay-created file content with normalized LF line endings so the streaming progress scenario passes on Windows while retaining EOL-aware line-count coverage. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: sync merged AHP protocol Regenerate the vendored protocol from agent-host-protocol main at 8e0a9bbf after the Ready metadata refinement merged. Keep JSON-RPC parse-error typing in the VS Code transport shim rather than the generated protocol surface. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: throttle streamed tool progress on time only The geometric growth gate required each update to add 25% more input, so streamed edits updated less and less often and appeared to stall on large arguments. Throttle on a shared 50ms interval instead, and suppress updates whose rendered message is unchanged so the steadier cadence does not re-send identical rows. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: raise streamed tool display interval to 100ms Derive the streaming test waits from the shared interval constant so they do not silently fall back to asserting the final force-flush when the interval changes. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Extract Agent Host provider service (#332481) * Extract Agent Host provider service Move provider registration, routing, authentication fan-out, MCP handling, and lifecycle ownership out of AgentService. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Simplify Agent Host service registration Register core and host defaults directly, then apply test substitutions explicitly after core registration. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Move provider diagnostics to provider service (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Update AgentService tests for provider ownership (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

agentHost: Attribute telemetry to initiating clients (#330982) * agentHost: attribute telemetry to initiating clients Plumb VS Code client telemetry identity through AHP and attach the complete known initiator context to attributable Agent Host events without replacing host identity. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: address client attribution feedback Fix test registration, propagate initiator context through provider operations and Claude edit telemetry, and retain identity in AHP diagnostic logs. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add Agent Host E2E coverage and expand protocol scenarios (#326493) * Add Agent Host E2E coverage and scenarios (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Stabilize Agent Host E2E tests across platforms (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Gate macOS-recorded Agent Host snapshots on Windows (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Use behavior snapshots for Agent Host scenarios (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add Agent Host settings commands to editor window (#325187) * Add Agent Host settings commands to editor window (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Use Agent Host enablement context key (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Use camelCase in Agent Host config editor (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>