aibrahim-oai

This commit performs a significant **architectural refactoring** by extracting all core **skill loading, configuration, and management logic** into a new, dedicated `codex-core-skills` crate. The `codex-core` crate is updated to become a thin integration layer, now consuming skill-related functionalities from this new module, while new configuration types like `SkillsConfig` and `project_root_markers` are introduced in `codex-rs/config`. This change enhances modularity and separation of concerns, affecting how skills are discovered, configured, and invoked across the `app-server` and `core` components. The refactoring also includes moving skill injection, invocation utilities, and remote skill management, establishing a clearer, dedicated API for all skill-related operations.

This commit **refactors** the project by **extracting** the existing analytics events client into a new, dedicated **`codex-analytics`** crate. The core analytics logic, including `AnalyticsEventsClient` and various tracking functions, has been moved from `codex-core` into this new, independent module. Consequently, the **`codex-core`** and **`app-server`** modules have been updated to import and utilize the analytics client from its new location, ensuring proper dependency management and improved modularity across the codebase. This change centralizes analytics functionality, making it more maintainable and independent.

This commit performs a significant **refactoring** by **extracting core plugin identifiers and load-outcome types** into a **new `codex-plugin` crate**. This architectural improvement moves definitions like `PluginId`, `LoadedPlugin`, and `PluginLoadOutcome`, along with their associated parsing and validation logic, out of the `codex-core` module. Consequently, the **`codex-core` plugin management subsystem** (`codex-rs/core/src/plugins/manager.rs`, `marketplace.rs`, `store.rs`) is updated to consume these types from the newly created crate. This change enhances modularity, improves separation of concerns, and promotes reusability of fundamental plugin definitions across the project.

This commit performs a significant **refactoring** by extracting shared plugin-related utilities into a new **`codex-utils-plugins`** crate. It centralizes common constants such as `TOOL_MENTION_SIGIL` and `PLUGIN_TEXT_MENTION_SIGIL`, along with functions like `plugin_manifest_name` and `plugin_namespace_for_skill_path` for resolving plugin namespaces and manifest paths. The **`codex-core`** module is updated to consume these newly extracted utilities, replacing local definitions with imports from the new crate. This **maintenance** effort improves modularity, reduces code duplication, and ensures consistent handling of plugin metadata across the system.

This commit **refactors** the codebase by **extracting** instruction fragment and user instruction types into a **new `codex-instructions` crate**. This modularization effort moves `ContextualUserFragmentDefinition`, `UserInstructions`, and `SkillInstructions` along with their associated logic and tests from `codex-core` into their own dedicated library. The `codex-core` module, specifically `codex-rs/core/src/contextual_user_message.rs` and `codex-rs/core/src/instructions/mod.rs`, is updated to consume these types from the new crate. This change reduces the internal complexity of `codex-core`, improves overall code organization, and enhances the reusability and maintainability of the instruction definitions across the project.

This commit performs a significant **refactoring** by **extracting the `rollout` functionality** from the `codex-rs/core` crate into a new, dedicated **`codex_rollout` crate**. Concurrently, general **path utility functions** are moved into a separate **`codex_utils_path` crate**. The **`codex-rs/core`** module is updated to re-export these functionalities, reducing its internal complexity and improving modularity. This **code extraction** introduces a new `RolloutConfigView` trait and `RolloutConfig` struct within `codex_rollout`, centralizing configuration for features like `metadata`, `recorder`, and `state_db`.

This commit performs a significant **refactoring** by **relocating shared string truncation utilities** from the `codex-rs/core` module into the more appropriate and reusable **`codex-rs/utils/string`** crate. Specifically, byte-based and token-based middle truncation logic, including functions like `truncate_middle_chars` and `approx_token_count`, are now centralized within a new `truncate` module. Additionally, a new utility crate, **`codex-rs/utils/output-truncation`**, is introduced to house specialized text and function output item truncation helpers, while the `TruncationPolicy` in `codex-rs/protocol` gains new budget calculation methods. This improves code modularity across the **`core`**, **`utils`**, and **`protocol`** subsystems, laying the groundwork for future features that will leverage these shared helpers.

This commit performs a significant **refactoring** by extracting all shared Git-related utilities into a new, dedicated crate named `codex-git-utils`. This centralizes common Git logic, including `GitInfo` helpers and the new `GitSha` newtype struct, which were previously scattered or located within the `core` crate. The change impacts numerous modules across the project, including **`app-server`**, **`chatgpt`**, **`cloud-tasks`**, **`protocol`**, **`secrets`**, **`state`**, and **`tui`**, all of which are updated to import and utilize the new crate. This modularization improves code organization and reusability, enabling future features like stacked rollout work to depend on a single, consistent source for Git information without carrying their own Git info modules.

This commit **enhances the user experience** by **adjusting the voice capture initiation delay** within the chat composer. It **increases the space-hold timeout** from 500 milliseconds to 1 second before voice recording begins, aiming to **prevent accidental voice capture**. This configuration change is applied consistently across both the **TUI client** (`codex-rs/tui/src/bottom_pane/chat_composer.rs`) and the **TUI app server** (`codex-rs/tui_app_server/src/bottom_pane/chat_composer.rs`). Users will now need to hold the spacebar for a slightly longer duration to activate voice input.

This commit **refactors** the **TUI's realtime conversation handling** to unify how various stop events are processed. It centralizes the logic for terminating realtime conversations, ensuring that triggers like UI actions, Ctrl+C, or the deletion of associated meters all follow a consistent shutdown path. This change primarily affects the `app.rs` and `chatwidget.rs` components within both `codex-rs/tui` and `codex-rs/tui_app_server`, introducing new helper functions like `stop_realtime_conversation_from_ui` and `stop_realtime_conversation_for_deleted_meter`. The primary goal is to improve the **robustness and predictability of realtime termination**, preventing inconsistent state or side effects during shutdown.

This commit introduces a **new capability** to the **App Server v2 protocol** by adding a `thread/realtime/transcriptUpdated` notification. This notification is emitted from live transcript deltas, providing more granular real-time updates with flat `threadId`, `role`, and `text` fields. The change primarily affects the **real-time conversation handling** within the `app-server` and includes comprehensive updates to the protocol schemas, documentation, and tests. The **TUI application** is also updated to acknowledge this new notification, enabling clients to react to incremental transcript changes more efficiently. This enhancement improves the responsiveness and detail of real-time conversation streams.

This commit performs a significant **refactoring** by **extracting the feature flag system into a new, dedicated `codex-features` crate**. This change enhances **modularity** by centralizing feature configuration, resolution, and warning logic. Consequently, all dependent crates, including **`codex-core`**, **`app-server`**, **`cli`**, **`mcp-server`**, and **`tui`**, have been updated to import and utilize the new `codex_features` crate for their feature-related operations and APIs. This ensures a cleaner separation of concerns and simplifies future maintenance and development of the feature management system across the project.

This commit undertakes a significant **refactoring** effort by **extracting all authentication implementation and token data** from the `codex-core` crate into a new, dedicated `codex-login` crate. This move centralizes the authentication logic, enhancing **modularity** and **separation of concerns** within the project. While `codex-login` now houses the core authentication manager, error types, and token definitions, `codex-core` continues to re-export these components to ensure **backward compatibility** for existing callers. Various dependent modules, including `app-server`, `cli`, `exec`, and `tui`, have been updated to reflect the new import paths or utilize the re-exports, streamlining the overall architecture.

This commit **refactors** the project structure by extracting the **terminal detection logic** into a new, dedicated `codex-terminal-detection` workspace crate. The `core/src/terminal.rs` module and its associated tests have been moved, and all direct consumers across the `cli`, `core`, `mcp-server`, `tui`, and `tui_app_server` modules have been updated to import terminal APIs like `user_agent`, `terminal_info`, `TerminalName`, and `Multiplexer` from this new crate. This **architectural improvement** enhances modularity and promotes better separation of concerns. The change makes the **terminal detection capabilities** independently reusable and maintainable across the `Codex` project, reducing coupling with the main `core` library.

This commit implements a **logic correction** within the **realtime websocket API** (`codex-rs/codex-api`) to refine data handling for different protocol versions. It specifically **prevents the active transcript from being moved to the handoff request** when processing events from **non-V1 realtime event parsers**, which implies **V2 realtime** events. This **fix** ensures that transcripts are only included where appropriate, **correcting data flow** and preventing unnecessary or incorrect data inclusion for the newer V2 system.

This commit introduces a **feature enhancement** to the **realtime conversation handoff mechanism**, ensuring that all agent final messages are consistently prefixed with an "Agent Final Message" label. The `conversation_handoff_append_message` function in the `realtime_websocket` endpoint of the `codex-api` now prepends this identifier to output for both v1 and v2 realtime systems. This **standardizes the output format**, providing clearer identification of agent final messages for downstream consumers. Consequently, **test assertions** across the `codex-api` and `codex-core` modules have been updated to reflect this new expected message structure.

This commit significantly improves the robustness and user experience of **realtime conversations** within the **TUI** by centralizing and enhancing session termination logic. It **refactors** the `chatwidget` components to ensure proper cleanup and closure of live realtime sessions upon various events, including **errors, Ctrl+C interruptions, and active meter removal**. This **maintenance and enhancement** effort also introduces **new capabilities** by adding a fallback `audio_device` module for non-Linux builds, enabling broader platform support for voice input features. The changes are thoroughly validated by comprehensive **new tests** covering these termination scenarios, ensuring more reliable and predictable realtime interactions.

This commit **refactors** the **realtime conversation management** within `codex-rs/core` to unify all shutdown paths. It ensures that failures during startup, input processing, or transport are routed through a single mechanism, guaranteeing a consistent error/closed lifecycle and clearing session state only once. This significantly improves the **robustness** and **predictability** of realtime session termination, with updated and new tests validating the improved error handling.

This commit introduces a **versioning mechanism for realtime conversations**, specifically gating advanced audio interruption logic. It adds a `RealtimeConversationVersion` enum and threads this version identifier through the `app-server-protocol`, `app-server`, `core`, and `tui_app_server` components. The primary impact is within the **TUI's audio input handling**, where `RealtimeAudioBehavior` and `RealtimeInputBehavior` are used to ensure that **playback-aware mic gating and playback interruption features are exclusively enabled for v2 conversations**, leaving v1 on a legacy path. This is a **feature addition and refactoring** to manage different realtime audio behaviors based on protocol version, preventing unintended interactions with older conversation types.

This commit provides a **bug fix** and **test maintenance** by addressing flakiness in the **approval matrix testing system**. Specifically, it refactors the `WriteFile` scenario within `codex-rs/core/tests/suite/approvals.rs` to replace non-deterministic shell-based file I/O with a reliable `python3 -c` script using explicit UTF-8 encoding. This change ensures that approval tests accurately measure product logic rather than shell parsing behavior, significantly improving **test reliability** and **diagnosability** by logging generated commands and results.