Megan Rogge

This commit performs significant **maintenance** and **refactoring** within the **Terminal Contrib's Chat Agent Tools** by centralizing the auto-approval logic for terminal commands. It introduces a new utility file, `terminalToolAutoApprove.ts`, to house shared functions like `isTerminalAutoApproveAllowed`, which are now used by both the `runInTerminal` and `sendToTerminal` tools. This change eliminates duplicated code, particularly in `runInTerminalTool.ts` and `sendToTerminalTool.ts`, ensuring a consistent and more maintainable auto-approval process for commands executed via these chat agent tools. The update streamlines the internal workings of how terminal commands are automatically approved, impacting the **Chat Agent Tools** subsystem.

This commit performs **test cleanup** by **removing specific test suites** and their associated configurations from the `vscode-api-tests` extension. It targets scenarios where **shell integration is explicitly disabled** for the `chat.runInTerminal` functionality, eliminating tests that are no longer necessary or relevant. This **maintenance** effort also includes a **refactoring of the test structure** within `chat.runInTerminal.test.ts`, streamlining the overall test suite.

This commit introduces a **new capability** within the **Terminal Chat Agent Tools** subsystem by adding the `SendToTerminalTool`. This tool allows chat agents to send commands directly to existing background terminals, significantly enhancing automation and interaction. It also includes new helper functions like `buildCommandDisplayText` and `normalizeCommandForExecution` for robust command processing, which are leveraged by the new tool. Furthermore, the existing `runInTerminalTool` is updated to reference the new `sendToTerminal` tool and utilize these shared helper functions, streamlining terminal command execution via chat. This expands the chat agent's ability to control and automate terminal workflows.

This commit performs **maintenance** by temporarily **skipping a flaky test** within the `vscode-api-tests` extension. Specifically, the test case in `extensions/vscode-api-tests/src/singlefolder-tests/chat.runInTerminal.test.ts` that runs in a sandbox environment is now disabled. This action prevents intermittent CI failures caused by the unreliable test, ensuring a more stable continuous integration pipeline. The test is skipped "for now," indicating a temporary measure until the underlying flakiness can be addressed.

This commit introduces a **new capability** to **detach background terminal processes**, allowing them to continue running even after VS Code is closed. This is achieved by integrating a `CommandLineBackgroundDetachRewriter` within the **Terminal Chat Agent Tools**, which modifies commands using `nohup` on POSIX systems and `Start-Process` for PowerShell. The `RunInTerminalTool` now utilizes this rewriter, and a new setting, `DetachBackgroundProcesses`, provides user control over this behavior. This enhancement ensures greater persistence for long-running tasks initiated through the terminal.

This commit **updates developer guidelines** by adding explicit instructions to avoid using `sleep` in favor of the more appropriate `await_terminal` tool. This **documentation enhancement** aims to improve the robustness and efficiency of asynchronous operations within the system. By promoting the use of `await_terminal`, developers are guided towards non-blocking waits, preventing potential performance issues or deadlocks associated with `sleep` calls. This change primarily impacts **developer workflow** and **code quality standards** for asynchronous programming.

This commit introduces a **new capability** to the **chat widget's question carousel**, specifically within `src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatQuestionCarouselPart.ts`. It implements a sorting mechanism that prioritizes **default question options**, moving them to the top of the list for both single and multi-select scenarios. This enhancement affects how options are rendered via `renderSingleSelect` and `renderMultiSelect`, and how answers are retrieved, improving the user experience by making common choices more accessible. The change is thoroughly validated with updated and new tests in `chatQuestionCarouselPart.test.ts` to ensure correct reordering and value mapping.

This commit **reintroduces a critical bug fix** for the **Chat accessibility** feature, specifically addressing how inline references are presented. It **restores the correct formatting and display of various reference types**—including URIs, file locations, and workspace symbols—within the `ChatResponseAccessibleProvider.provideContent` method. This ensures that users relying on assistive technologies receive properly structured and navigable links in the **accessible view for chat responses**. The change significantly improves the **accessibility of chat interactions** by making these references understandable, and new test cases have been added to validate the fix.

This commit **fixes a bug** in the **Chat feature's tip dismissal logic**, ensuring a more consistent user experience. It **refactors** the `listenForTipCommandExecution` function within `src/vs/workbench/contrib/chat/browser/chatTipService.ts` to **always dismiss chat tips** when an enabled command is clicked, removing a previous conditional check. This change guarantees that tips reliably disappear after user interaction, preventing unexpected persistence. New test cases were added to validate this corrected dismissal behavior, improving the overall stability of the **Chat UI**.

This commit delivers a **bug fix** addressing an issue where **PowerShell commands produced chained output** when executed via the `run_in_terminal` feature, specifically impacting macOS users. It modifies the `richExecuteStrategy`, `basicExecuteStrategy`, and `noneExecuteStrategy` within the **terminal chat agent tools** to conditionally disable `forceBracketedPasteMode` when sending text to the terminal. This ensures proper command execution and output, resolving a critical terminal interaction problem for **PowerShell on macOS**. The change prevents incorrect or duplicate output, improving the reliability of terminal command execution.

This commit introduces a **refactoring** to improve the management of **terminal shell integration timeouts**, specifically for testing. It adds a `ShellIntegrationTimeoutOverride` enum to the `terminal` platform, allowing the `getShellIntegrationTimeout` function to disable the timeout when `DisableForTests` is specified. This primarily affects **terminal environment configuration** and **API tests**, which are updated to utilize this new override for more stable execution. Additionally, the `cursorMoveTimeout` within the `NoneExecuteStrategy` for **chat agent tools** is reduced from 5000ms to 1000ms, potentially optimizing command execution feedback.

This commit **fixes accessibility issues** within the **platform action list component**, particularly impacting the "Other Models" action list. It **improves screen reader support** by adding the `aria-expanded` attribute to section toggle items in `src/vs/platform/actionWidget/browser/actionList.ts` and refining the `onListClick` logic. Concurrently, the accessibility provider for the **Chat feature's model picker** (`src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts`) is updated to correctly handle section toggles, ensuring proper role and state reporting. This comprehensive **accessibility improvement** enhances usability for assistive technologies across relevant UI elements.

This commit introduces **growth-oriented enhancements** across two key areas. It **enables chat tips by default** within the **Chat feature**, removing its experimental flag to improve user discoverability and guidance. Concurrently, it refactors the **Terminal profile management** by removing `IConfigurationService` dependencies from `getTerminalActionBarArgs` and explicitly **elevates AI profiles**, ensuring they are always prioritized and easily accessible within the **Terminal editor, view, and menus**. This streamlines the user experience for both chat interactions and AI-powered terminal workflows by making these features more prominent and readily available.

This commit **fixes a bug** in the **`GetTerminalOutputTool`** within the **`terminalContrib` chat agent tools** by improving its handling of invalid or unknown terminal IDs. It **clarifies the expected terminal ID contract** by updating the tool's description and input schema to include a UUID pattern for validation. The `invoke` method now gracefully **returns an error message** when an invalid or unknown terminal ID is provided, preventing unexpected behavior. New unit tests have been added to ensure the correct error handling and successful output retrieval for valid IDs, making the tool more robust and predictable for users.

This commit **fixes** an issue where commands executed via the **integrated terminal** could be misinterpreted, particularly when originating from **chat agent tools**. It introduces and utilizes **bracketed paste mode** by adding an optional `forceBracketedPasteMode` parameter to the `runCommand` and `sendText` methods within the `terminal` API and its `terminalInstance` implementation. This ensures that commands are correctly parsed when "pasted" into the terminal. Consequently, the `basicExecuteStrategy`, `noneExecuteStrategy`, and `richExecuteStrategy` within the `chatAgentTools` subsystem are updated to explicitly enable this mode, significantly improving the reliability of command execution for these tools.

This commit introduces a **new capability** to the **`terminalContrib/chatAgentTools` subsystem**, specifically enhancing the `runInTerminal` tool. It **enables terminal commands to execute freely** without requiring explicit user approval when the session is operating in `Autopilot` or `Bypass Approvals` modes. The change involves a **refactoring** of the auto-approval logic within `CommandLineAutoApproveAnalyzer` and `RunInTerminalTool`, removing denial tracking and circuit breaker mechanisms to streamline command execution. This ensures a smoother workflow for users in these specific modes by conditionally applying auto-approval analysis based on session settings, with corresponding test updates to validate the new behavior.

This commit **fixes a bug** within the **Terminal Chat Agent Tools** where the `get_task_output` function would return empty results when attempting to retrieve output from **background tasks**. The `provideFeedback` method in `src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/task/getTaskOutputTool.ts` is modified to correctly handle output collection for these tasks. This is achieved by introducing start markers and ensuring proper disposal of resources, which **enhances the reliability** of the chat agent's interaction with long-running terminal processes. The change ensures accurate feedback from background tasks while preserving the existing behavior for single-run, reused terminals.

This commit **reverts** a previous change that introduced **bracketed paste mode** for **multiline executed terminal text** within the **terminal** feature. Specifically, this **maintenance** revert undoes the logic in `src/vs/workbench/contrib/terminal/browser/terminalInstance.ts`'s `sendText` function, which was responsible for enabling this behavior. The change restores the terminal's previous handling of multiline input, likely addressing issues or regressions caused by the original implementation. Associated tests in `src/vs/workbench/contrib/terminal/test/browser/terminalInstance.test.ts` related to bracketed paste mode are also removed.

This commit provides a **bug fix** for the **Chat feature**, specifically addressing a **contrast issue** within the **question carousel widget**. It adjusts the background and foreground colors for selected items in `chatQuestionCarousel.css` to significantly improve readability when using **light themes**. Additionally, it introduces specific styling for focused states, enhancing the overall user experience and accessibility of the chat interface.

This commit introduces a **new feature** enabling users to **collapse chat questions** within the **Chat UI's question carousel**. It implements the core collapsing logic in `chatQuestionCarouselPart.ts`, handling UI elements, state management via `toggleCollapsed` and `persistDraftState`, and presentation updates, complemented by new styles in `chatQuestionCarousel.css`. The `chatQuestionCarouselData.ts` model is extended with a `draftCollapsed` property to ensure the collapsed state is persisted across sessions. This enhancement improves the usability and visual management of chat interactions by allowing users to hide detailed question content when not needed.