Michael Reed

This commit **refactors** the **`skparagraph` module's `FontCollection` class** by implementing the **Pimpl idiom**. It introduces a private `FaceCache` to encapsulate internal data, specifically moving the **`SkTHash` dependency** and the typeface hash map from the public `FontCollection.h` header into `FontCollection.cpp`. This **maintenance** change significantly **reduces public API dependencies** for `FontCollection` users, improving **build times** by preventing unnecessary inclusion of `SkTHash` in client code. Methods like `findTypefaces` and `clearCaches` were updated to interact with this new private implementation.

This commit **reapplies a previous change** to replace bespoke `CLZ` and `CTZ` implementations in `src/base/SkMathPriv.h` with C++20 standard library functions. It specifically **restores the portable fallback for `SkCLZ_portable`** to resolve compiler warnings, addressing a **bug** related to compiler compatibility. This **refactoring** effort modernizes **core math utility functions** and updates `tests/MathTest.cpp` to verify the new `SkCLZ` and `SkCLZ_portable` implementations. The change improves maintainability and leverages standard library features, ensuring robust and compliant math utilities.

This commit **refactors** the **`TypefaceFontProvider`** within the `skparagraph` module by migrating its internal font family registration mechanism. It switches from using `SkTHashMap` and `SkString` to **`std::unordered_map` and `std::string`** for managing font data. This **internal implementation change** required updating methods such as `onCountFamilies`, `onMatchFamily`, and `registerTypeface` to correctly interact with the new standard library containers. A significant benefit of this **refactoring** is the **removal of a `#include` dependency** on a `src/` file from the header, enhancing modularity and reducing compilation coupling for the `skparagraph` module.

This commit **refactors** the **base mathematical utility functions** in `src/base/SkMathPriv.h` by replacing custom implementations of count leading zeros (`SkCLZ`) and count trailing zeros (`SkCTZ`). It now leverages the standard C++ library functions `std::countl_zero` and `std::countr_zero` from the `<bit>` header. This **maintenance** change simplifies the codebase, reducing the need for bespoke bit manipulation logic and potentially improving performance and portability by relying on optimized standard library routines. The internal implementation of functions like `SkNextLog2_portable` and `SkPrevLog2_portable` is updated, but the public API remains unchanged for consumers of these utilities.

This commit performs **maintenance cleanup** by **removing obsolete benchmarks** from the `bench` module. Specifically, it targets performance tests related to mathematical operations that are no longer relevant or necessary. This action streamlines the benchmarking suite, reduces technical debt, and ensures that only active and useful performance tests are maintained within the project.

This commit performs significant **refactoring** to improve **header hygiene** by relocating internal implementations of **SkTHash** and **SkChecksum** from `src/core/` to new private headers, `include/private/base/SkTHash_impl.h` and `include/private/base/SkChecksum_impl.h`. It also moves math utility functions like `SkNextLog2` and `SkNextPow2` from `src/base/SkMathPriv.h` to `include/private/base/SkMath.h`. The original `src/core/SkTHash.h` and `src/core/SkChecksum.h` are converted into redirectors to maintain compatibility, while various **Skia modules** (`skottie`, `skparagraph`, `svg`) are updated to directly reference the new private paths. This **maintenance** effort clarifies dependency boundaries and prevents public headers from directly including internal `src/` paths. Build configurations (`gn/core.gni`, `BUILD.bazel`) are updated to reflect these changes across the project.

This commit performs a **refactoring** of the **`skparagraph` module's `ParagraphCache` component** to improve encapsulation and maintainability. It moves internal cache implementation details from `modules/skparagraph/include/ParagraphCache.h` into a new private `Cache` struct defined within `modules/skparagraph/src/ParagraphCache.cpp`. All cache-related operations, including `turnOn`, `count`, `findParagraph`, and `updateParagraph`, are updated to interact with this new internal structure. This **maintenance** effort aims to reduce the public surface area of the `ParagraphCache` header, preventing `src` directory includes in public APIs and enhancing API hygiene without altering external behavior.

This commit **fixes a memory allocation bug** within the **`SkPathData`** module, specifically addressing how space is reserved for conic sections. Previously, the system overallocated memory by treating conics as `SkPoint` objects; this change **corrects the calculation** to use `sizeof(float)`, which is the accurate size for conic data. This **optimization** prevents unnecessary memory consumption, leading to a **reduced memory footprint** and improved efficiency when handling paths containing conic elements in the `Skia` graphics library.

This commit introduces a significant **refactoring** to the **`SkPathBuilder` API** to unify point semantics, ensuring that methods consistently accept `SkPoint` objects rather than separate `x` and `y` coordinates. Specifically, the `addCircle` method is updated, and a new `setLastPoint` method is introduced to behave like `setPoint(last_index)`, deprecating the older `setLastPt`. This **API modernization** impacts **path construction** and downstream components like **path stroking and joining logic** in `SkStrokerPriv.cpp`, requiring updates across various fuzzing and testing utilities to align with the new `SkPoint`-based interface.

This commit **removes obsolete test cases** from the `SkPath` module's **testing infrastructure**. These tests previously verified the preservation of nonfinite values within paths, a behavior that is no longer relevant due to a **fundamental change in `SkPathData`'s behavior**. With `SkPathData`, nonfinite paths now correctly become empty, rendering the old preservation tests moot. This **maintenance and cleanup task** deletes already disabled, **dead code**, streamlining the test suite to accurately reflect current `SkPath` functionality.

This commit performs **code cleanup** within the **Skia graphics library's path geometry system** by removing obsolete type definitions from `SkPath.h`. These types were remnants from an older "editable path" feature that is no longer in use. The change **refactors** the header to improve maintainability and reduce unnecessary declarations, with no functional impact on existing Skia applications.

This commit performs a significant **refactoring** by **migrating gradient creation** to use the new `SkShaders` API, specifically `SkShaders::LinearGradient`, and **eliminating direct dependencies on `SkGradientShader.h`**. This modernization impacts core **Skia gradient implementations**, **CanvasKit bindings**, **WebGPU bindings**, and the **minimal iOS Metal app**, along with various internal modules like **SVG** and **viewer tools**. The change standardizes gradient construction through helper functions and a `GradientBuilder` struct, improving consistency and maintainability across the codebase.

This commit performs a significant **refactoring** by updating numerous gradient creation calls across the codebase to utilize the **new `SkShaders` and `SkGradient` API**. This modernization effort affects **Skia's font ports** (e.g., `src/ports/SkScalerContext_win_dw.cpp`, `src/ports/SkTypeface_fontations.cpp`) and a wide array of **viewer examples and slides**. The change standardizes gradient handling for linear, radial, sweep, and two-point conical gradients, often incorporating `SkColor4f` for color specification. This ensures consistency and leverages the latest API for improved functionality or efficiency within the Skia rendering engine.

This commit performs a significant **refactoring** across various parts of the Skia project, specifically modernizing how gradients are defined and created. It migrates numerous **gradient benchmarks**, **fuzzing utilities**, and **viewer examples** to utilize a **new `SkGradient` span API** for colors and positions, alongside the `SkColor4f` structure for precise color representation. This change standardizes gradient creation, potentially improving memory safety and API clarity by leveraging `std::span` or similar concepts. The widespread updates ensure that internal tools and tests align with the updated gradient infrastructure, promoting consistency and robustness in gradient handling.

This commit performs **code cleanup** and **refactoring** by **removing unused methods** from the `SkPathPriv` utility class. Specifically, `SkPathPriv::IsEffectivelyEmpty` was inlined directly into the `SkPathBuilder::addPath` method, simplifying the **path building core logic** within `src/core/SkPathBuilder.cpp`. Concurrently, `SkPathPriv::GetPoint` was removed, with affected **tests** in `tests/PathBuilderTest.cpp` updated to use a new local helper function. This effort improves **code maintainability** and reduces the codebase's footprint by eliminating dead or redundant code.

This commit performs a significant **API refactoring** of the **gradient rendering system** within Skia. It updates numerous **benchmarks**, **GM tests**, and **unit tests** to utilize the new `SkGradient` struct and `SkShaders` factory methods, such as `SkShaders::LinearGradient` and `SkShaders::RadialGradient`. This change consolidates gradient definitions, moving away from direct usage of `SkGradientShader.h` towards `SkGradient.h` and leveraging `SkSpan` for color and offset arrays. The widespread updates ensure consistency and maintainability across the codebase by standardizing the creation of gradient shaders.

This commit performs a significant **refactoring** and **dead code removal** related to the `SkPathRef` component within the **Skia graphics library's path handling infrastructure**. It streamlines the codebase by removing conditional compilation comments from `include/core/SkFont.h` and `include/core/SkRegion.h`, and redefining internal array type aliases in `include/core/SkPathBuilder.h` that previously relied on `SkPathRef`. Key utility functions such as `TransformDirAndStart` and `DeduceRRectFromContour` are moved from `SkPathRef` to `src/core/SkPathPriv.cpp`, while `HasComputedBounds` is entirely removed. This **maintenance** effort simplifies the **path representation and editing mechanisms** by eliminating deprecated or unused functionality, with corresponding **test cases** in `tests/PathTest.cpp` also being removed to reflect these changes.

This commit performs an **IWYU (Include What You Use) refactoring** within the **`gm` (Graphics Module)** test suite. It specifically **adds the necessary include for `SkColorPriv.h` to `gm/graphitestart.cpp`**. This ensures that the file explicitly declares all its direct header dependencies, improving build hygiene and preventing implicit includes. The change is a **maintenance** task that enhances code robustness and clarity without altering runtime functionality.

This commit **refactors** the creation of **gradient shaders** across numerous **Graphics Module (GM) tests**, completing the conversion to use spans for gradients. It updates existing gradient implementations (linear, radial, and sweep) to utilize the **new `SkShaders` API** and the **`SkColor4f` format for colors**. This **maintenance** work ensures that the GM test suite aligns with modern Skia API usage, improving the consistency and future compatibility of gradient rendering validation. The changes affect various test cases, from basic gradient drawing to more complex scenarios involving compositing, meshes, and tile modes.

This commit **refactors** a significant number of **Graphics Module (GM) tests** to utilize the modern **`SkGradient` API** for creating various gradient types, including linear, radial, and sweep. This **maintenance effort** also involves updating color definitions to **`SkColor4f`** and incorporating new **`withAlpha` and `withAlphaByte` helper methods** added to `SkRGBA4f` for improved alpha manipulation. By converting these tests, the codebase gains consistency in gradient creation and color handling, aligning with current API best practices and preparing for future evolutions of the graphics library.