Somhairle MacLeòid

This commit **adds a regression test** to the **`vitest-pool-workers`** module, specifically targeting the **`WorkerEntrypoint` environment mocking** functionality. The new test, located in `fixtures/vitest-pool-workers-examples/rpc/test/unit.test.ts`, ensures that this critical aspect of worker environment simulation behaves as expected. This **enhances the test suite's robustness**, preventing future regressions and improving the overall reliability of the `vitest-pool-workers` integration.

This commit introduces a **new capability** for the **Bonk** agent, enabling it to **read triggering comments** and **act on fixup requests**. The `.github/workflows/bonk.yml` workflow is updated to construct prompts from these comments, integrating this new functionality. Concurrently, the `.opencode/agents/bonk.md` documentation is revised to prioritize triggering comments as tasks and prevent unnecessary re-reviews on fixup requests, significantly improving Bonk's operational efficiency and responsiveness.

This commit implements a **bug fix** within the **Miniflare** runtime, specifically targeting the `dispose()` method. It modifies the temporary directory cleanup process to be **best-effort**, which directly addresses and prevents `EBUSY` errors that were occurring on **Windows** operating systems. This change ensures more robust and reliable resource disposal, particularly for users on Windows, by gracefully handling situations where temporary files might still be in use.

This commit introduces a **fix** within the **`vitest-pool-workers`** module to address excessive log spam. It specifically adds the `'CODE_MOVED for unknown code block'` message, originating from `workerd`, to the list of messages ignored by the Vitest test pool. This **maintenance** change significantly improves the developer experience by reducing noise in test output, making logs cleaner and more focused. The update prevents irrelevant warnings from cluttering the console during test execution.

This commit introduces **support for `@voidzero-dev/vite-plus-test`** as an alternative test runner within the `vitest-pool-workers` package. It enhances the **`vitest-pool-workers`** module by updating its package.json parsing and version compatibility checks, specifically through `getUpstreamVitestVersion` and `assertCompatibleVitestVersion`, to recognize this new distribution. Furthermore, the `setTimeout` monkeypatching logic in `src/worker/index.ts` was adjusted via `monkeypatchedSetTimeout` to correctly identify calls originating from `@voidzero-dev/vite-plus-test`, ensuring proper test execution. This **new capability** allows users to leverage the `vitest-pool-workers` with an expanded range of Vitest-compatible test environments.

This commit introduces **regression tests** for the **Vitest Workers pool** to validate the behavior of the `onUnhandledError` callback. Specifically, it ensures that unhandled promise rejections are correctly intercepted and processed by this error handling mechanism within the worker environment. This work enhances the **reliability of error reporting** within the `vitest-pool-workers` environment, preventing silent failures and improving diagnostic capabilities for users. The new tests, located in `unhandled-rejection.test.ts`, solidify the expected error handling behavior for this specific pool implementation.

This commit **improves the testing experience** within the **`vitest-pool-workers`** module by suppressing specific `stderr` noise. It **fixes** an issue where irrelevant error messages, specifically `broken.outputGateBroken; jsg.Error: Instance dispose`, would appear in the console during **Workers testing workflows**. By adding these patterns to the ignored list in `packages/vitest-pool-workers/src/pool/index.ts`, the change ensures cleaner and more focused test output, enhancing developer productivity and clarity.

This commit delivers a **bug fix** addressing a **crash** within **Wrangler's `vitest-pool-workers` integration**. Previously, the test runner would fail when a `wrangler.jsonc` configuration included an `assets` binding but omitted the `directory` property, leading to an unhandled error during asset setup. The fix modifies the asset processing logic within `getMiniflareOptionsFromConfig` and `unstable_getMiniflareWorkerOptions` to gracefully skip asset initialization in this specific scenario, preventing the crash. This change significantly improves the **robustness of Wrangler's platform integration** for Vitest, ensuring that tests can run without interruption even with potentially incomplete asset configurations, and is validated by a new **regression test suite**.

This commit **updates the RTTI compatibility date** for the **`vitest-pool-workers`** package. It modifies the `packages/vitest-pool-workers/scripts/rtti/query.mjs` script to **dynamically use the current date**, replacing a previously hardcoded value. This **maintenance fix** ensures that the RTTI compatibility checks within the worker pool are always current and accurate. The change prevents potential issues arising from outdated compatibility dates, thereby improving the robustness of the `vitest-pool-workers` module.

This commit introduces a **new feature** by adding the `adminSecretsStore()` function to the **`vitest-pool-workers`** testing environment. This function provides **administrative access to secrets store bindings**, allowing developers to programmatically manage them within their `cloudflare:test` suites. The implementation involves defining a new `SecretsStoreSecretAdmin` interface within the `Miniflare` package and exposing the `adminSecretsStore` utility for use in tests. This enhancement significantly **improves the testability** of Cloudflare Workers that interact with secrets stores by enabling comprehensive testing of secret management workflows.

This commit provides a **bug fix** for the **`vitest-pool-workers`** module, specifically addressing its **module fallback resolution logic**. It modifies the `packages/vitest-pool-workers/src/pool/module-fallback.ts` file to ensure that file extension probing (e.g., adding `.js` or `.ts`) is only performed for `require()` calls and not for `import` statements. This change aligns the resolution behavior with the **Node.js specification** for ESM, preventing incorrect module resolution for extensionless internal imports in ESM dependencies. The fix improves the reliability of **ESM dependency resolution** within the worker pool and is validated by a new dedicated test case.

This commit delivers a **bug fix** for the **`vitest-pool-workers`** package, specifically addressing how **Durable Object interactions** handle HTTP redirect responses. Previously, the `runInDurableObject` utility would automatically follow redirects, potentially leading to incorrect test assertions or unexpected behavior. The fix involves configuring `stub.fetch` with `redirect: "manual"` within the `runInStub` function in `packages/vitest-pool-workers/src/worker/durable-objects.ts`, ensuring redirects are now processed explicitly. This change improves the accuracy and reliability of tests involving Durable Objects that issue redirects, validated by a new **regression test** in `fixtures/vitest-pool-workers-examples/durable-objects/test/direct-access.test.ts`.

This commit **fixes a bug** in **Miniflare's glob pattern matching** that led to files with double extensions, like `.wasm.test.ts`, being incorrectly identified by their first extension. The shared `globsToRegExps` utility now accepts an `endAnchor` option, which is leveraged by `compileModuleRules` to ensure glob patterns precisely match the end of a filename. This **enhances the accuracy of module type detection** within **Miniflare**, particularly for **WebAssembly modules**, preventing misclassification and ensuring correct loading. New unit and regression tests have been added to validate this fix and prevent future issues with complex filenames.

This commit introduces a **regression test** within the `vitest-pool-workers` package to specifically verify the correct **Istanbul coverage reporting across multiple test files**. The new test in `coverage.test.ts` ensures that coverage data is accurately aggregated and reported when tests span several source files. To support this, the test project's `global-setup.ts` was updated to include `@vitest/coverage-istanbul` as a development dependency. This **maintenance** work enhances the reliability of the coverage feature, preventing future regressions in this critical area.

This commit introduces a **30-second timeout** for `waitUntil` promises within the **`vitest-pool-workers`** package, preventing test suites from hanging indefinitely. This **stability improvement** ensures that the **Vitest Workers pool** can reliably complete test runs even if `waitUntil` operations are slow or stuck. If a `waitUntil` promise exceeds the timeout, it is abandoned, and a warning is logged, preventing test execution from blocking. A new test case verifies that the `waitForWaitUntil` function correctly handles these timeouts, ensuring the robustness of the test runner.

This commit provides a crucial **bug fix** for the **`vitest-pool-workers`** package, resolving issues where **dynamic `import()`** statements failed to execute correctly within **worker entrypoints** and **Durable Object (DO) handlers**. The fix involves patching the module runner's transport in `packages/vitest-pool-workers/src/worker/index.ts` to ensure that `invoke()` calls are properly executed within the Runner DO's I/O context. This enables reliable testing of Cloudflare Workers that leverage dynamic imports, significantly improving the compatibility of the test environment. Comprehensive new example fixtures and regression tests have been added to validate this functionality and prevent future regressions.

This commit **improves the issue triage process** by updating the **developer documentation** within `.github/skills/issue-review.md`. This **documentation update** clarifies and streamlines the internal guidelines for reviewing and categorizing incoming issues. The change primarily affects the **developer workflow** for issue management, aiming to enhance efficiency and consistency in handling project issues.

This commit **restores the `/exchange` endpoint** within the **`edge-preview-authenticated-proxy`** package, addressing a previous omission or malfunction. As a **fix**, it reintroduces critical logic in `src/index.ts` for handling token exchange requests, including the `handleTokenExchange` function and new error classes like `NoExchangeUrl` and `ExchangeFailed`. Comprehensive new test cases in `tests/index.test.ts` validate the endpoint's functionality, ensuring robust authentication and token exchange operations for the proxy.

This commit introduces a **new feature** to the **`create-cloudflare` CLI tool**, enabling **source map uploading by default** for newly created projects. The `updateWranglerConfig` function within `packages/create-cloudflare/src/wrangler/config.ts` is modified to automatically set `upload_source_maps = true` in the generated `wrangler.toml` configuration. This default behavior streamlines debugging workflows for most projects, with the notable exception of **Python projects**, which are explicitly excluded. The change is reflected in updated test cases and documented via a new changeset entry, improving the out-of-the-box developer experience.

This commit **introduces a new agent persona** for the **Bonk GitHub Action**, enhancing its automated operations. It updates the `.github/workflows/bonk.yml` workflow to leverage a new version of the action, configuring it to operate under this defined persona. Concurrently, a new Markdown file, `.opencode/agents/bonk.md`, is added to formally define the persona's characteristics and operational guidelines. This **feature enhancement** provides a more structured and consistent interaction model for the Bonk action, impacting how automated processes using it behave.