github.com-facebook-hermes

Replace use of private serde and quote internals Summary: This crate is blocking a serde update. These APIs are not public and not stable over time. You are not supposed to use them. https://www.internalfb.com/code/fbsource/[45d32fb2e51fdc0f015a735a18b284c2aae7fc98]/xplat/hermes/unsupported/hermes/crates/hermes_estree_codegen/src/codegen.rs?lines=11%2C360%2C736%2C755%2C790 Reviewed By: diliop Differential Revision: D82673555 fbshipit-source-id: bf094b3f5ed122d4e86d184a02a900300c8c4c36

Backport multi-session debugger support Summary: Backport from static_h of D90862351 (a bugfix) and the multi-session debugger stack (D90585931 through D90862348). Local changes on top of the graft: - Add CDPAgentMultiDebuggerTest.cpp to srcs and CDPAgentTest.h to headers in BUCK - Add DebuggerDomainCoordinator.cpp to srcs and DebuggerDomainCoordinator.h to exported_headers in api.bzl Reviewed By: fbmal7 Differential Revision: D90864318 fbshipit-source-id: db510823dcfd79e1655e4071df5b8883a89d2a94

Add intermediate state for the Hermes Root API Summary: This diff adds the Hermes Root API interface, but keeps the static functions within HermesRuntime still. This is a necessary intermediate step for RN ([see failing tests here](https://github.com/facebook/react-native/actions/runs/14800547982/job/41558052598?pr=51082)), which depends on the version of Hermes that is on `main`, which does not have the Root API yet. Once this lands, we can land the next diff in the stack that migrates all the usages to `makeHermesRootAPI`, and remove all the static methods from `HermesRuntime`. Reviewed By: neildhar Differential Revision: D74594455 fbshipit-source-id: 7db62051082e3384b0f5215a2262cda58208db9f

Apply breakpoints when Debugger domain is re-enabled Summary: While working on Performance panel, I've noticed a native crash happening, if user has any breakpoints set. This happens because of the failed assertion here: https://www.internalfb.com/code/fbsource/[fc5f1ebf5b8d]/xplat/hermes/API/hermes/cdp/DebuggerDomainAgent.cpp?lines=196 When user starts recording a trace in Performance panel, Chrome DevTools will send `Debugger.disable` method. Once recording stops, it will send `Debugger.enable`. At this step the referenced assertion will fail. What changes with this diff: - We will clear `HermesBreakpoints` in `CDPBreakpoints` on `disable`, because they are already cleared in local debugger: https://www.internalfb.com/code/fbsource/[fc5f1ebf5b8d]/xplat/hermes/API/hermes/cdp/DebuggerDomainAgent.cpp?lines=233-236 This is covered by BreakpointsSurviveDomainReload test. - We will apply any persisted `CDPBreakpoints` to local Hermes Debugger again on `enable` method. This is covered by BreakpointsSurviveDomainReloadAndCorrectlyPauseVM test. Reviewed By: dannysu Differential Revision: D70251389 fbshipit-source-id: 2aad376c2d3b64819abd6bb397ac33781e108bff

Setup Hermes publishing to Maven for commitlies and releases on Android and iOS (#1752) Summary: Pull Request resolved: https://github.com/facebook/hermes/pull/1752 This setups publishing Android and iOS artifacts on commits and releases to be used by React Native. ## Motivation Reduce CI time by decreasing the number of Hermes builds currently running on the React Native repo by moving them to the Hermes repo with less traffic. Reviewed By: cortinico Differential Revision: D79163000 fbshipit-source-id: e80978a4f32e48c5c2c0ce5574e1956319693697

Add `TypedArray`, `UInt8Array` in JSI Summary: X-link: https://github.com/facebook/react-native/pull/56158 Add TypedArray and Uint8Array types to JSI with supporting APIs. New types: - `TypedArray`: Base class for all typed arrays - `Uint8Array`: Uint8Array type extending TypedArray New IRuntime APIs: - `getBuffer(TypedArray)`: Get underlying ArrayBuffer - `getByteOffset(TypedArray)`: Get byte offset property - `getByteLength(TypedArray)`: Get byte length property - `getLength(TypedArray)`: Get length property - `createUint8Array(size_t)`: Create Uint8Array with length - `createUint8Array(ArrayBuffer, offset, length)`: Create from ArrayBuffer - `isUint8Array(Object)`: Check if object is Uint8Array Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95245175 fbshipit-source-id: 33e7f5d9de42bfcc0b7a57c681fdd73711c2bb13

Fix JSI `isArray` method to match JS `Array.isArray` Summary: There is currently an assumption that JSI arrays are always `vm::JSArrays`, and thus JSI method `isArray` only return true if it is an `vm::JSArray` . However, the JSI spec states `isArray` should follow JS `Array.isArray`. This diff fixes this and treats `JSI::Array` as normal objects. Grafted 1b61dd500b2b3bdab4771663672c375d7ed1b7d6 (D67408956) - Grafted xplat/static_h to xplat/hermes Reviewed By: lavenzg Differential Revision: D82322325 fbshipit-source-id: 382eab6d67401281727b1bf27fdc7c0bbabc9fc4

Align HermesRuntime with SH and make non-static methods virtual Summary: Make these functions virtual so that it is simpler to have multiple different Hermes versions loaded in the same application. This should not add any overhead in most cases, since Hermes is typically a separate dynamic library, so invocations of these methods would take an indirection through the PLT. Also add methods that currently are implemented in SH, with throwing implementations. Reviewed By: tmikov Differential Revision: D69219627 fbshipit-source-id: 6eabd012d05ff1c529750781a5f560881e2fc700

Run hermesc builds in Hermes repo (#1729) Summary: Pull Request resolved: https://github.com/facebook/hermes/pull/1729 Moves building HermesC from React Native repo. ### Motivation Reduce CI time by decreasing the number of Hermes builds currently running on the React Native repo by moving them to the Hermes repo with less traffic. Reviewed By: cipolleschi Differential Revision: D77869024 fbshipit-source-id: 9b801d6659d9d3fea3bdb4157f8ef62a8fcaf79f

Introduce format-agnostic API for JS Sampling (#1603) Summary: Pull Request resolved: https://github.com/facebook/hermes/pull/1603 This diff adds a new API on `HermesRuntime`, which will emit a `struct` with all necessary information about completed JavaScript Sampling Profile. This `struct` can later be used by other third parties, such as React Native. The reason for creating a data source, and not just providing a stream to which Hermes will emit serialized information is that on React Native side we own the format in which data should be serialized, together with the data from other potential sources, such as User Timings, Interactions, Network, etc. HermesRuntime will have 2 new API endpoints: - `dumpAsProfile`. A method on `HermesRuntime` instance, which returns `Profile` that contains all relevant information about the recorded sampled stack trace. - `dumpAsProfilesGlobal`. A static method, which returns vector of all recorded Profiles for all registered sampling profiler instances. The actual conversion to Trace Event Format will hapen on React Native side, Hermes will only emit data structure that is agnostic to format and operates only with JavaScript runtime-level entities and general stuff: call stack frame information, timestamps, information about OS process and thread where sampling occured. Reviewed By: dannysu Differential Revision: D67353585 fbshipit-source-id: 291a3daee4114e4fe3545bbcb94faa8ecc534443

Remove unused build scripts in hermes (#1814) Summary: Pull Request resolved: https://github.com/facebook/hermes/pull/1814 Removes old scripts used to build apple frameworks which became obsolete after D77869024. Reviewed By: cipolleschi Differential Revision: D85324112 fbshipit-source-id: 574794b77b8049e9a46e4e49c81c83fd1677e854

Use IHermes, use shared_ptr<jsi::Runtime> in Synth Traces in all other version of Hermes Summary: Cast into `IHermes` in Synth Traces when Hermes-specific runtime functionalities are used, instead of performing `dynamic_cast` While we are here, also updated all unique_ptr usages of `jsi::Runtime` to shared_ptr. Reviewed By: neildhar Differential Revision: D73525167 fbshipit-source-id: 8aab275bc4fa3fd1f5c34f162710296859af9096

Fix get_assigned_codepoints bug Summary: The very first range element in `Assigned` was incorrectly being generated as `(0,0)`. Fix this by initializing `cp_begin` to `None`. Reviewed By: neildhar Differential Revision: D68579548 fbshipit-source-id: ece91e7ca929f251adc485f3aec395b6566f52f0

Add JSI APIs `setRuntimeData` and `getRuntimeData` Summary: X-link: https://github.com/facebook/react-native/pull/50197 Adds `setRuntimeData` and `getRuntimeData` JSI APIs. This provides a convenient way for users to store some custom data associated with an UUID. For the default implementation of this feature, store the runtime data in the global map that is shared between all VMs. This is done to keep JSI lightweight and stateless, instead of adding data members. Changelog: [Internal] Reviewed By: neildhar Differential Revision: D71579532 fbshipit-source-id: 553e28fbf80c93e268d475860197a00d2c5bacf7

Add createFromUtf16 JSI method Summary: X-link: https://github.com/facebook/react-native/pull/48211 Adding the default implementation for `createFromUtf16` method for JSI String and PropNameId. Changelog: [Internal] Reviewed By: tmikov Differential Revision: D67070206 fbshipit-source-id: 47297e6ae3028ee0e101628aab5bc076fcbbdebc

Add deleteProperty support to Synth Traces Summary: Adds Synth Trace record and support for `deleteProperty` API so that it can be recorded and replayed. Grafted ea07908273fe5d3e7b5105c4d692dc9fdd7decef (D80375910) - Grafted xplat/static_h to xplat/hermes Reviewed By: lavenzg Differential Revision: D81332811 fbshipit-source-id: 4377a98ec74971efa8bbf659531dc14b7d7d086b

Add Value override for has/get/setProperty Summary: X-link: https://github.com/facebook/react-native/pull/52910 For `get/has/setProperty`, we should also be able to take in a generic JS Value as the property key. This change adds the Value overload for these APIs. The default implementation will use `Reflect.get`, `Reflect.has`, and `Reflect.set`. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D79120823 fbshipit-source-id: 7e2e5ff1ca93397c549e7dd922797fe77aa97940

Add `IHermes` interface to all other versions of Hermes Summary: Add interface `IHermesRuntimeV0` to contain the Hermes-specific runtime functionalities. The interface `HermesRuntime` will inherit from both `jsi::Runtime` and `IHermesRuntimeV0` to provide functionalities from both. This allows usage of `HermesRuntime` to remain the same for now while we work on migrating these usages to query the appropriate interface incrementally. Reviewed By: tmikov Differential Revision: D71132856 fbshipit-source-id: 75bcf3e18c2e4c9c3134c654af72c1bc0f1c08ca

Add createFromUtf16 support in Synth Traces Summary: Original Author: chitsai@meta.com Original Git: 8454740c321622579bb7a475ba56d8486ac56fc0 Original Reviewed By: dannysu Original Revision: D67070209 Add SynthTrace support for `createFromUtf16` APIs in Synth Traces, so we can record and replay them properly. Reviewed By: neildhar Differential Revision: D68599522 fbshipit-source-id: 1b472347ecaaf0f6bcbf8014a08d49a11a1282ed

JSError: never fail with invalid getter target" (#1621) Summary: Pull Request resolved: https://github.com/facebook/hermes/pull/1621 JS developers expect this to work and print "undefined": ```js function MyEror() { this.message = "MyError"; } MyError.prototype = Object.create(Error.prototype); try { throw new MyError(); } catch (e) { print(e.stack); } ``` We give it to them by preventing the getter from throwing errors. In V8 this is implemented differently by attaching the getter to the actual instance. Arguably, this makes sense, because property reads shouldn't throw. Add and update tests. - Grafted path static_h to hermes Reviewed By: avp Differential Revision: D69757360 fbshipit-source-id: 216e870e82c941a985020202dc14aa5948164da8