Michael Reed

Move editing methods into separate .cpp - also completely removes most editing methods, not just making them private. - will allow us to start the migration to a new backend - also move non-skpath priv methods to priv.cpp - found some lurkers calling setPt(), so migrated them to an equivalent method in SkPathBbuilder. Change-Id: Ic283723b8e3c3ba98cdd86efdce0dbeb7e223557 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1072196 Commit-Queue: Mike Reed <mike@reedtribe.org> Reviewed-by: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Florin Malita <fmalita@google.com>

Reapply "Move editing methods into separate .cpp" Fix: no fix needed This reverts commit 5c9f73070c10f01fa2296d78dc5b332dba7add85. Change-Id: I1883d6ecfaac3a2e098e66150c96696fdad829d7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1074796 Reviewed-by: Florin Malita <fmalita@google.com> Reviewed-by: Daniel Dilan <danieldilan@google.com> Commit-Queue: Mike Reed <mike@reedtribe.org>

Change patheffect's virtual to take pathbuilder - this rippled into pathmeasure and stroking Plenty more to do after this: - more sites (internal) that can change to take builders - we might start passing PathRaw as const src&, so that the builder itself can be an input, rather than first snapping off a path. Change-Id: I689da01f58d4829a6cde0c60d18b2deaafa5a6fd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1012818 Reviewed-by: Florin Malita <fmalita@google.com> Commit-Queue: Mike Reed <mike@reedtribe.org> Reviewed-by: Daniel Dilan <danieldilan@google.com>

Use SkSpan in SkFont API Many of these have more than one span, so the impl has to deal with the case when not all of the sizes agree. - the src size is the maximum - each dst receives the min(src.size, dst.size) This CL also moves the unspanned-api guard to SkTypes.h, since it is now used in several headers. Change-Id: I32e4afa3258847e780cf921b8c4c94d7cfe2f172 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1001137 Reviewed-by: Florin Malita <fmalita@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Reed <mike@reedtribe.org>

SkPathData : immutable replacement for SkPathRef - Immutable (except for lazy convexity...?) - Single allocation -- all arrays in single block - Only stores coordinates, not filltype or volatility Known task for follow-up CLs - Lazily compute convexity, or up-front? - UniqueID M1 Max benchmarks 23/23 MB 238 114ns 119ns 122ns 144ns 8% ▁▁▁▆▂▃▂▂█▂ nonrendering path_transform_affine_path 23/23 MB 330 128ns 132ns 133ns 143ns 4% ▁▃▃▃▃▆▃▃▂█ nonrendering path_transform_affine_builder 23/23 MB 601 68.9ns 72.1ns 72.2ns 79ns 4% ▄▃▄▄▁█▃▃▁▃ nonrendering path_transform_affine_data Change-Id: I2f1f2c4e8b3c4bcd3a65e35749c536b19a315ad6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1025416 Reviewed-by: Florin Malita <fmalita@google.com> Reviewed-by: Kaylee Lubick <kjlubick@google.com> Commit-Queue: Mike Reed <mike@reedtribe.org>

Use path builder in viewer and examples Change-Id: I16d4bc5b604ab8bc399ae225b17032471f3b9c62 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1071476 Reviewed-by: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Reed <mike@reedtribe.org>

Convert to span api for gradients Change-Id: I9005e2696d5e4022dc08585ec3025f4b7fb10572 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1123676 Commit-Queue: Mike Reed <mike@reedtribe.org> Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Florin Malita <fmalita@google.com>

Convert some gms to use spanified Gradients API - this removes gradients4f and gradients4f_nodither, and they are now complete dups of gradients and gradients_nodither Change-Id: I799603e60159550c8e9802296264cb50e6192b32 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1124456 Reviewed-by: Florin Malita <fmalita@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Reed <mike@reedtribe.org>

Change matrix::invert to return optional Change-Id: Ic2aaed096397a9f71515148d2fb329be6a705cf2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1021716 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Florin Malita <fmalita@google.com> Commit-Queue: Mike Reed <mike@reedtribe.org>

Adapt remaining callers to be compatible with std::span After this lands, we need only test that our clients can build with the std::span alias, after which we can remove the flag. Change-Id: I80eb1c0356eea816865e51b2236b7b10b1dff1f2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1104616 Reviewed-by: Florin Malita <fmalita@google.com> Commit-Queue: Mike Reed <mike@reedtribe.org> Reviewed-by: Eric Boren <borenet@google.com>